[Security] Add message to login page by sorenlouv · Pull Request #51557 · elastic/kibana

sorenlouv · 2019-11-24T21:01:28Z

This change makes it possible to add an optional message to the login page. This is useful for announcing scheduled maintenance, and providing help with credentials - something we currently need the ability to do for observability.

Example 1: Maintenance announcements

Example 2: Help with credentials (corporate)

Example 3: Help with credentials (test cluster)

elasticmachine · 2019-11-24T21:45:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ca27aae15a532c69c4b53f83275586462179cca3

elasticmachine · 2019-11-25T07:25:31Z

Pinging @elastic/kibana-security (Team:Security)

elasticmachine · 2019-11-25T08:24:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d6562da0f39631c948e663fa79a5c3fbb2a30a88

elasticmachine · 2019-11-25T09:52:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 74fb84df705be1ed186fa8a5e66283f3533473c1

watson · 2019-11-25T10:25:44Z

For scheduled maintenance announcements, I think it would be better to have a banner that also appears after login and not only during login. A user can be logged in for a long time and not see the login screen. So I'm not sure about how big a benefit this will be only on the login screen.

However, I like the idea of having a message like this related to the actual login procedure.

sorenlouv · 2019-11-25T10:38:16Z

@watson True, maintenance announcements might not be the best use case. Help to login is specifically the problem we are trying to solve. For the Kibana instances I'm responsible for I'm regularly pinged by people who want to know how they can login. For this specific purpose it would be very beneficial to be able to add login instructions (or link to such) directly above the login box.

I'm sure there are also other use cases people might want to use this message for so tried to keep it a little generic.

elasticmachine · 2019-11-25T10:43:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fc45cd8a19a7293a509240df6efc587d064f3f0e

jbudz · 2019-11-25T12:05:44Z

We do have
too, only after login but could be reused for a global. I do think there's utility with a server defined message like this too

legrego · 2019-11-25T14:30:31Z

@alexfrancoeur would this satisfy #36586?

I think there is a small part of #17298 in here too, but that is mostly concerned with post-login messages

sorenlouv · 2019-11-25T14:35:37Z

More generally, the ability to add a custom html site link to login page for admin user to specify text of the link and link to external page through the management interface in Kibana.
#36586 (comment)

Users cannot use custom html but they can use markdown, so links and formatting is possible (and I'd argue safer and easier than allowing custom html).

legrego

It looks like the "logout message" prevents the new login assistance message from rendering:

I'd expect both messages to appear, but they're both using the primary EuiCallOut color, so I worry one might get lost next to the other. This might be ok, but maybe @elastic/kibana-design has an opinion?

legrego · 2019-11-25T15:07:35Z

Users cannot use custom html but they can use markdown, so links and formatting is possible (and I'd argue safer and easier than allowing custom html).

++ I'd be wary of custom HTML too, and I think markdown allows for a sufficient level of control here.

cchaos · 2019-11-25T15:46:54Z

I would not put the custom message inside of an EuiCallOut. Rendering can be tricky with custom content (even just Markdown) as seen by @legrego's example. Though if it is just plain Markdown, it should get wrapped in an EuiText (size="s") block.

sorenlouv · 2019-11-25T16:31:16Z

@cchaos Better?

…se EuiText instead of EuiCallOut

sorenlouv · 2019-11-25T16:37:33Z

It looks like the "logout message" prevents the new login assistance message from rendering:

@legrego Good point. Since c229c4c it now renders the login message independently of the other messages.

cchaos

@sqren Yes, I think it's fair to say that not all custom messages time or content sensitive. Which is why pulling it out of the EuiCallOut makes the most sense. If it is, they can add their own emphasis via text formatting.

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

sorenlouv · 2019-11-25T16:40:32Z

Login Page with logout callout and login assistance message:

Edit: text made smaller since I took the screenshot

elasticmachine · 2019-11-25T18:05:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 56dd17d

sorenlouv · 2019-11-25T20:25:36Z

I would assume we'd want our callout though to be closest to the login form (just above the panel).

Okay, I'll flip them around.

sorenlouv · 2019-11-25T20:28:28Z

cchaos

Looks good from my end. 👍

elasticmachine · 2019-11-25T21:58:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ebf2c8c

watson

LGTM 👍

sorenlouv · 2019-11-26T12:19:06Z

I'll merge this for now to unblock some things. LMK if I should change the name xpack.security.loginAssistanceMessage to something else (naming is hard) and I can do that in a follow-up PR.

* [Security] Add loginAssistanceMessage to login page * Fix tests * Fix login_page.test.tsx * Fix defaultValue * Render login assistance message independently of other messages and use EuiText instead of EuiCallOut * Use small text Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Flip order of message around

kresss · 2020-01-06T23:57:38Z

Do users still see this new message if they are logging into a PKI protected kibana? Ideally they should have to acknowledge the banner before being logged in even if they are not providing username/password style credentials.

kobelb · 2020-01-07T00:35:25Z

Do users still see this new message if they are logging into a PKI protected kibana? Ideally they should have to acknowledge the banner before being logged in even if they are not providing username/password style credentials.

They do not. This message is only shown on the login page, which only works with the Reserved/Native/File realms in Elasticsearch.

Would you mind chiming in on either #18176 and/or #17298 with your specific needs?

kresss · 2020-01-07T14:29:56Z

Would you mind chiming in on either #18176 and/or #17298 with your specific needs?

@kobelb I think that our requirements are stated in #18176. The comment from @mbarretta restates the requirement.

kobelb · 2020-01-07T16:20:40Z

Thanks @kresss

cauemarcondes · 2020-01-20T11:22:18Z

Tests:
IE: ✅
Chrome: ✅
Firefox: ✅
Safari: ✅

azasypkin · 2020-04-23T06:17:42Z

6.8/6.8.9: 2baa83b

* [Security] Add loginAssistanceMessage to login page * Fix tests * Fix login_page.test.tsx * Fix defaultValue * Render login assistance message independently of other messages and use EuiText instead of EuiCallOut * Use small text Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Flip order of message around

sorenlouv requested review from a team as code owners November 24, 2019 21:01

sorenlouv added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Nov 25, 2019

sorenlouv added release_note:enhancement v7.6.0 labels Nov 25, 2019

jbudz approved these changes Nov 25, 2019

View reviewed changes

legrego reviewed Nov 25, 2019

View reviewed changes

legrego added the v8.0.0 label Nov 25, 2019

sorenlouv added 4 commits November 25, 2019 17:23

[Security] Add loginAssistanceMessage to login page

2b50343

Fix tests

5c19d97

Fix login_page.test.tsx

2a38b82

Fix defaultValue

2d9a9d8

Render login assistance message independently of other messages and u…

c229c4c

…se EuiText instead of EuiCallOut

cchaos reviewed Nov 25, 2019

View reviewed changes

Comment thread .../legacy/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx Outdated

Use small text

56dd17d

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

Flip order of message around

ebf2c8c

cchaos approved these changes Nov 25, 2019

View reviewed changes

watson approved these changes Nov 26, 2019

View reviewed changes

sorenlouv merged commit e8e5174 into elastic:master Nov 26, 2019

sorenlouv deleted the add-login-assistance-message branch November 26, 2019 12:19

sorenlouv mentioned this pull request Nov 26, 2019

[7.x] [Security] Add message to login page (#51557) #51708

Merged

v1v mentioned this pull request Dec 26, 2019

Customise Kibana login with an assistance message elastic/apm-integration-testing#702

Merged

ogupte added the apm-test-plan-7.6.0 label Jan 15, 2020

legrego mentioned this pull request Jan 17, 2020

Configuration option to add custom link and text to Kibana login screen #36586

Closed

cauemarcondes self-assigned this Jan 20, 2020

cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 20, 2020

watson mentioned this pull request Jan 27, 2020

Anonymous access #18331

Closed

azasypkin mentioned this pull request Mar 31, 2020

Login page layout improvements #61144

Closed

azasypkin mentioned this pull request Apr 22, 2020

[6.8][Security] Add message to login page. #64158

Merged

azasypkin added v6.8.9 backported labels Apr 22, 2020

Conversation

sorenlouv commented Nov 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 24, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

watson commented Nov 25, 2019

Uh oh!

sorenlouv commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

Uh oh!

jbudz commented Nov 25, 2019

Uh oh!

legrego commented Nov 25, 2019

Uh oh!

sorenlouv commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

legrego commented Nov 25, 2019

Uh oh!

cchaos commented Nov 25, 2019

Uh oh!

sorenlouv commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sorenlouv commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sorenlouv commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

sorenlouv commented Nov 25, 2019

Uh oh!

sorenlouv commented Nov 25, 2019

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

Uh oh!

watson left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv commented Nov 26, 2019

Uh oh!

kresss commented Jan 6, 2020

Uh oh!

kobelb commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kresss commented Jan 7, 2020

Uh oh!

kobelb commented Jan 7, 2020

Uh oh!

cauemarcondes commented Jan 20, 2020

Uh oh!

azasypkin commented Apr 23, 2020

sorenlouv commented Nov 24, 2019 •

edited

Loading

sorenlouv commented Nov 25, 2019 •

edited

Loading

sorenlouv commented Nov 25, 2019 •

edited

Loading

sorenlouv commented Nov 25, 2019 •

edited

Loading

sorenlouv commented Nov 25, 2019 •

edited

Loading

sorenlouv commented Nov 25, 2019 •

edited

Loading

kobelb commented Jan 7, 2020 •

edited

Loading