Repository navigation
[Telemetry] Migrate ui_metric plugin to NP under usageCollection - #51972
Merged
Bamieh merged 37 commits intoDec 13, 2019
Merged
Conversation
…metric_to_usage_collection
…metric_to_usage_collection
…metric_to_usage_collection
…metric_to_usage_collection
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
waiting on this PR to get merged first before merging mine: #52251 To resolve renaming configs issue between legacy and NP plugins. |
…Bamieh/kibana into telemetry/ui_metric_to_usage_collection
TinaHeiligers
left a comment
Contributor
There was a problem hiding this comment.
A few nits and comments, otherwise the code looks good.
I'm doing a smoke test in Chrome and will re-review once that's done.
TinaHeiligers
approved these changes
Dec 13, 2019
TinaHeiligers
left a comment
Contributor
There was a problem hiding this comment.
The code changes look good and make the types much clearer. Thanks for giving the default max wait time for all collectors such a descriptive name, it'll be very obvious now!
I also ran a test in Chrome and Safari and the move of the ui_metric code works as expected.
LGTM!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…tic#51972) * move cloud dir to plugins from legacy * create ui_metrics in NP * migrate first plugin * ui_metric plugin uses npStart * sinin mock * karma mocks * type check fix * rename old configs * fix mocks and use configs * use fo debug * ui_metric deprecation configs * remove commented out code * remove unused type import * mock ui_metric in client_integration * jest.mock ui/new_platform * fix all failing tests * platform team code review fixes * reset interval back to default * apm cypress config use usageCollection * revert kibana.yml change * remove license type from NP def * undo revert of NP type * code review fixes * report schema in a separate dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
ui_metricto New platformui_metricunderusage_collectionplugin.ui_metricplugin code.ui_metricsui_metricsDev Docs
Migrates
ui_metricsto NP underusageCollection.