Skip to content

Update Node.js to version 10.18.0 - #52865

Merged
watson merged 2 commits into
elastic:masterfrom
watson:bump-node
Dec 18, 2019
Merged

Update Node.js to version 10.18.0#52865
watson merged 2 commits into
elastic:masterfrom
watson:bump-node

Conversation

@watson

@watson watson commented Dec 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Get up-to-date with the latest 10.x version of Node.js

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@watson watson added the Feature:Hardening Harding of Kibana from a security perspective label Dec 12, 2019
@watson watson self-assigned this Dec 12, 2019
@watson watson added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Dec 12, 2019
@elasticmachine

elasticmachine commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-security (Team:Security)

@azasypkin azasypkin added the Team:Operations Kibana-Operations Team label Dec 12, 2019
@elasticmachine

elasticmachine commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@watson
watson marked this pull request as ready for review December 12, 2019 15:19
@watson
watson requested a review from a team as a code owner December 12, 2019 15:19
mistic
mistic approved these changes Dec 12, 2019
View reviewed changes

@mistic mistic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@watson watson changed the title Bump node to 10.17.0 Update Node.js to version 10.17.0 Dec 12, 2019
@watson

watson commented Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

Can someone verify that I did what I'm supposed to in regards to "This includes a feature addition or change that requires a release note and was labeled appropriately". I've never made a PR that should be included in the release notes before.

@tylersmalley

tylersmalley commented Dec 12, 2019

Copy link
Copy Markdown
Member

@watson there is information on that here: https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process

In short, the title is used in the release notes so make sure it summarize what the PR accomplishes in language that is meaningful to the user. In general, use present tense (for example, Adds, Fixes) in sentence case.

For issues which are included in the blog post, which this one shouldn't, there are additional steps outlined to provide more details.

@watson

watson commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

v10.17.1 is scheduled to be released next week, so let's wait to merge this one until then. I'll update this PR with the new version once it lands.

@mistic

mistic commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

@watson the new 10.18.0 version was released. Can we update to it and move that PR forward ?

@watson watson changed the title Update Node.js to version 10.17.0 Update Node.js to version 10.18.0 Dec 18, 2019
@elasticmachine

elasticmachine commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

  • 💚 Build #15325 succeeded 59b3cffc1e268e5e3e2db44ed84e00a1b3f5629a
  • 💚 Build #15111 succeeded fac9646b966b6ddc5f3edb40c237fcba566fb7ba
  • 💔 Build #15068 failed d1f2973779f0aa2f9266b36a63b9a12268f4b556

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson
watson merged commit eadf8bf into elastic:master Dec 18, 2019
@watson
watson deleted the bump-node branch December 18, 2019 12:07
@watson watson mentioned this pull request Dec 18, 2019
Merged
watson added a commit that referenced this pull request Dec 18, 2019
@watson
Update Node.js to version 10.18.0 (#52865) (#53471)
ca01375
@chenrui333 chenrui333 mentioned this pull request Jan 22, 2020
Closed
2 tasks
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@watson
Update Node.js to version 10.18.0 (elastic#52865)
27702cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes
@legrego legrego legrego approved these changes
@mistic mistic mistic approved these changes

Assignees

@watson watson

Labels

Feature:Hardening Harding of Kibana from a security perspective release_note:enhancement Team:Operations Kibana-Operations Team Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@watson @elasticmachine @tylersmalley @mistic @legrego @kobelb @azasypkin