Repository navigation
[Maps] Vector style UI redesign - #53946
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
Author
|
@elasticmachine merge upstream |
thomasneirynck
left a comment
Contributor
There was a problem hiding this comment.
Seeing this in action makes so much more sense suddenly. That chainlink icon now just looks goofy.
Only minor nits in the comments.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Jan 6, 2020
thomasneirynck
left a comment
Contributor
There was a problem hiding this comment.
thx. with this PR, all the refactoring and UX-change prereqs in place to add categorical styling
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 6, 2020
* [Maps] style editor update * update label editor * update size editor * update orienation editor * i18n cleanup * deconstruct props * review feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jan 6, 2020
* [Maps] style editor update * update label editor * update size editor * update orienation editor * i18n cleanup * deconstruct props * review feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [Maps] style editor update * update label editor * update size editor * update orienation editor * i18n cleanup * deconstruct props * review feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the vector style UI as designed https://www.figma.com/file/01iMw3PXgLdlOktDXExT0Z/Maps-%7C-Categorical-Colors-Picker?node-id=201%3A1623.
The redesign is needed because users where often confused by the link button. Having a drop down with clear text
fixedandBy valueis much more intuitive.The redesign is also needed for styling by category. Styling by category will introduce more complexity to the form than the original design could handle. This PR lays the ground work for more more complex styling configurations.
Docs will need to be updated but those changes will come in a separate PR once styling by category is merged all UI changes are complete.