Repository navigation
[7.x] bfetch (#52888) - #53065
Merged
Merged
[7.x] bfetch (#52888)#53065
Conversation
* feat: 🎸 add bfetch plugin stub * feat: 🎸 add sample routes * feat: 🎸 implement streaming response * feat: 🎸 add Defer class * refactor: 💡 move Defer inot /common folder * feat: 🎸 add fromStreamingXhr() method * feat: 🎸 add split method * feat: 🎸 add fetchStreaming() function * test: 💍 fix test after refactor * test: 💍 add tests for fetStreaming() method * refactor: 💡 move removeLeadingSlash() to /common folder * feat: 🎸 expor stateful fetchStreaming() throuh plugin contract * chore: 🤖 clean up bfetch * chore: 🤖 prepare to replace ajax_stream by bfetch * Change ajax_stream to use new-line delimited JSON * refactor: 💡 move batched_fetch to use bfetch service * refactor: 💡 make use of defer() utility from kibana_utils * chore: 🤖 remove ajax_stream library * fix: 🐛 fix tests and inject fetchStreaming() method as dep * refactor: 💡 make split() operator more readable * refactor: 💡 improvee PR according to feedback * docs: ✏️ add fetchStreaming() reference * refactor: 💡 use NP logger, rename to createNDJSONStream() * chore: 🤖 adress Luke's review comments * chore: 🤖 add missing type
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: