Support "Deprecated" label in advanced settings by lizozom · Pull Request #54539 · elastic/kibana

lizozom · 2020-01-12T10:45:14Z

Summary

Support "deprecated" label in advanced settings
Mark courier:batchSearches as deprecated
Working with @gchaps to add a deprecation message to docs as well.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
~~Unit or functional tests were updated or added to match the most common scenarios~~
This was checked for keyboard-only and screenreader accessibility

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

mark courier:batchSearches as deprecated

elasticmachine · 2020-01-12T10:45:16Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

lizozom · 2020-01-12T10:49:23Z

@elasticmachine merge upstream

…/deprecation-label

Dosant

code lgtm

lizozom · 2020-01-13T13:01:38Z

@stacey-gammon @lukasolson What do you think?

…/deprecation-label

stacey-gammon · 2020-01-13T14:58:29Z

This is great!

cchaos

The UI LGTM. I saw just a couple things in the code and as mentioned, this still needs a deprecation statement in the docs.

Translate click aria label Use docLinks service

cchaos

👍 on the UI. Will you be adding the deprecation warning in the docs in this PR?

…/deprecation-label

lizozom · 2020-01-13T17:23:51Z

@cchaos #54594

This reverts commit c9512ce.

…/deprecation-label

kibanamachine · 2020-01-13T21:53:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 62e4573

History

💔 Build #19879 failed e1f0e6b
💔 Build #19840 failed c9512ce
💔 Build #19810 failed 468e22b
💚 Build #19574 succeeded 421981d
💔 Build #19567 failed d719885e3c659644d951a7024e2e7e9d0eacc9c8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Support deprecating label in advanced settings mark courier:batchSearches as deprecated * jest update * Add deprecation to UiSettingsParams type Translate click aria label Use docLinks service * Rename doc link * Remove url option from DeprecationSettings * Simplify code * Updated docs * Revert "Updated docs" This reverts commit c9512ce. * snapshots * docs

pgayvallet · 2020-01-14T07:51:29Z

+    // Warning: (ae-forgotten-export) The symbol "DeprecationSettings" needs to be exported by the entry point index.d.ts
+    deprecation?: DeprecationSettings;


Minor, but DeprecationSettings should be exported

* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...

* Support deprecating label in advanced settings mark courier:batchSearches as deprecated * jest update * Add deprecation to UiSettingsParams type Translate click aria label Use docLinks service * Rename doc link * Remove url option from DeprecationSettings * Simplify code * Updated docs * Revert "Updated docs" This reverts commit c9512ce. * snapshots * docs

Support deprecating label in advanced settings

9ea64b7

mark courier:batchSearches as deprecated

lizozom added Feature:New Platform v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 12, 2020

lizozom requested a review from a team as a code owner January 12, 2020 10:45

lizozom self-assigned this Jan 12, 2020

lizozom requested a review from cchaos January 12, 2020 10:46

Liza K added 2 commits January 12, 2020 13:41

jest update

a7ae50a

Merge remote-tracking branch 'upstream/master' into advanced-settings…

421981d

…/deprecation-label

lizozom force-pushed the advanced-settings/deprecation-label branch from d719885 to 421981d Compare January 12, 2020 11:43

lizozom changed the title ~~Support deprecating label in advanced settings~~ Support "Deprecated" label in advanced settings Jan 12, 2020

lizozom requested a review from Dosant January 12, 2020 15:41

Dosant approved these changes Jan 13, 2020

View reviewed changes

Comment thread src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js Outdated

Merge remote-tracking branch 'upstream/master' into advanced-settings…

74a9f1b

…/deprecation-label

mshustov reviewed Jan 13, 2020

View reviewed changes

Comment thread src/legacy/core_plugins/kibana/ui_setting_defaults.js

cchaos reviewed Jan 13, 2020

View reviewed changes

Comment thread src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js Outdated

Comment thread src/legacy/core_plugins/kibana/ui_setting_defaults.js Outdated

lizozom added the v7.5.2 label Jan 13, 2020

Add deprecation to UiSettingsParams type

e2154a3

Translate click aria label Use docLinks service

lizozom removed the v7.5.2 label Jan 13, 2020

Liza K added 2 commits January 13, 2020 18:26

Rename doc link

60c3a37

Remove url option from DeprecationSettings

2c7255b

lizozom requested a review from a team as a code owner January 13, 2020 16:28

Simplify code

468e22b

mshustov approved these changes Jan 13, 2020

View reviewed changes

cchaos approved these changes Jan 13, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into advanced-settings…

1a63438

…/deprecation-label

Liza K added 5 commits January 13, 2020 19:29

Updated docs

c9512ce

Revert "Updated docs"

4750561

This reverts commit c9512ce.

snapshots

e1f0e6b

Merge remote-tracking branch 'upstream/master' into advanced-settings…

d01a59c

…/deprecation-label

docs

62e4573

lizozom merged commit aa16a9d into elastic:master Jan 13, 2020

lizozom mentioned this pull request Jan 13, 2020

[7.x] Support "Deprecated" label in advanced settings (#54539) #54660

Merged

pgayvallet reviewed Jan 14, 2020

View reviewed changes

lukasolson mentioned this pull request Aug 19, 2021

[data.search] Remove deprecated courier:batchSearches advanced setting #109350

Merged

9 tasks

Navigation Menu

Repository navigation

Support "Deprecated" label in advanced settings - #54539

Support "Deprecated" label in advanced settings#54539
lizozom merged 14 commits into
elastic:masterfrom
lizozom:advanced-settings/deprecation-label

lizozom commented Jan 12, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 12, 2020

Uh oh!

lizozom commented Jan 12, 2020

Uh oh!

Dosant left a comment

Uh oh!

Uh oh!

lizozom commented Jan 13, 2020

Uh oh!

Uh oh!

stacey-gammon commented Jan 13, 2020

Uh oh!

cchaos left a comment

Uh oh!

Uh oh!

Uh oh!

cchaos left a comment

Uh oh!

lizozom commented Jan 13, 2020 •

edited

Loading

Uh oh!

kibanamachine commented Jan 13, 2020

Uh oh!

pgayvallet Jan 14, 2020

Uh oh!

lizozom Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

		// Warning: (ae-forgotten-export) The symbol "DeprecationSettings" needs to be exported by the entry point index.d.ts
		deprecation?: DeprecationSettings;

Conversation

lizozom commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 12, 2020

Uh oh!

lizozom commented Jan 12, 2020

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizozom commented Jan 13, 2020

Uh oh!

Uh oh!

stacey-gammon commented Jan 13, 2020

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom commented Jan 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Jan 13, 2020

💚 Build Succeeded

History

Uh oh!

pgayvallet Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lizozom commented Jan 12, 2020 •

edited

Loading

lizozom commented Jan 13, 2020 •

edited

Loading