Skip to content

[Maps] Categorical palettes - #54918

Merged
elizabetdev merged 2 commits into
elastic:masterfrom
elizabetdev:categorical-palettes
Jan 15, 2020
Merged

elizabetdev merged 2 commits into
elastic:masterfrom
elizabetdev:categorical-palettes

Conversation

@elizabetdev

Copy link
Copy Markdown
Contributor

Summary

On #54408 it was introduced 3 categorical color palettes: euiPaletteColorBlind() and two ColorBrewer palettes.

Both ColorBrewer palettes aren't fully color blind safe and have some contrast issues in dark/light modes.

For this reason and until we include more qualitative palettes into EUI, we decided to remove the ColorBrewer palettes.

@elizabetdev
elizabetdev requested a review from a team as a code owner January 15, 2020 15:42
@nreese nreese added release_note:fix v7.7.0 Team:Geo Former Team Label for Geo Team. Now use Team:Presentation and removed release_note:enhancement labels Jan 15, 2020
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese

nreese commented Jan 15, 2020 •

Copy link
Copy Markdown
Contributor

@miukimiu I removed the enhancement tag and replaced it with fix tag. Feature freeze (FF) was yesterday so no enhancements can be merged into 7.6 branch. I would consider this a bug fix and not an enhancement.

I also added v7.7.0 tag since this by the time this merges, 7.x will be 7.7 so this PR will needed to be backported to 7.x and 7.6.

@nreese nreese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@elizabetdev

Copy link
Copy Markdown
Contributor Author

Thanks @nreese!

@elizabetdev

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine

Copy link
Copy Markdown
Contributor

user doesn't have permission to update head repository

@thomasneirynck

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@elasticmachine

Copy link
Copy Markdown
Contributor

user doesn't have permission to update head repository

@elizabetdev

Copy link
Copy Markdown
Contributor Author

jenkins test this

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elizabetdev
elizabetdev merged commit ed3c899 into elastic:master Jan 15, 2020
elizabetdev added a commit to elizabetdev/kibana that referenced this pull request Jan 15, 2020
elizabetdev added a commit to elizabetdev/kibana that referenced this pull request Jan 15, 2020
elizabetdev added a commit that referenced this pull request Jan 15, 2020
elizabetdev added a commit that referenced this pull request Jan 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.6.0 v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants