Repository navigation
[Maps] Disable add layer button when flyout is open - #54932
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
requested review from
alexfrancoeur,
elizabetdev,
kindsun and
nreese
January 15, 2020 16:50
nreese
reviewed
Jan 15, 2020
nreese
left a comment
Contributor
There was a problem hiding this comment.
I like the idea. Just a few clean-ups in the code
elizabetdev
approved these changes
Jan 16, 2020
elizabetdev
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and lgtm! 🎉
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 22, 2020
thomasneirynck
added a commit
that referenced
this pull request
Jan 22, 2020
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal. Disable the add layer button when the flyout is open.
When the slide-out is open, it gets confusing sometimes when the add layer button is pressed, to determine what state exactly you're in as a user.
It's something a novice user often runs into it (also really annoying at demos). With this PR we just prevent this "broken" flow from happening altogether.