Repository navigation
Remove graphql types - #54176
Merged
Merged
Remove graphql types#54176
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
Author
|
@elasticmachine merge upstream |
simianhacker
self-requested a review
January 8, 2020 17:57
Contributor
Author
|
@elasticmachine merge upstream |
simianhacker
requested changes
Jan 8, 2020
Member
There was a problem hiding this comment.
There are a few more places where we can replace InfraMetricData with NodeDetailsMetricData:
x-pack/legacy/plugins/infra/public/pages/metrics/components/helpers.ts
x-pack/legacy/plugins/infra/public/pages/metrics/components/page_body.tsx
x-pack/legacy/plugins/infra/public/pages/metrics/containers/with_metrics.tsx
x-pack/legacy/plugins/infra/public/pages/metrics/types.ts
x-pack/legacy/plugins/infra/server/lib/domains/metrics_domain.ts
Everything else looks good.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Jan 9, 2020
* Fix server types * Remove graphql types from the frontend * More type cleanup * Replace more types. Delete unused files Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb
added a commit
that referenced
this pull request
Jan 14, 2020
* Fix server types * Remove graphql types from the frontend * More type cleanup * Replace more types. Delete unused files Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Fix server types * Remove graphql types from the frontend * More type cleanup * Replace more types. Delete unused files Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since we no longer use graphql on the backend, this PR refactors all code that references graphql types to point to our own io-ts types. This PR strips out all of the graphql references, except for references to the source configuration, log highlighting, and the schemas. Once we get source config off of graphql, we should strong consider deleting the schemas and the type files, so that no one is confused and accidentally imports the wrong type in the future. Fixes: #52950.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility