Skip to content

[Monitoring] Ensure setup mode work in a ccs environment - #54361

Merged
chrisronline merged 2 commits into
elastic:masterfrom
chrisronline:monitoring/setup_mode_ccs
Jan 9, 2020
Merged

chrisronline merged 2 commits into
elastic:masterfrom
chrisronline:monitoring/setup_mode_ccs

Conversation

@chrisronline

Copy link
Copy Markdown
Contributor

Fixes #54354

See the issue for testing steps.

Also, added a rudimentary test for each endpoint. Ideally, we have better CCS-based tests but that's a larger-term project.

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@igoristic igoristic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ Nice catch 👍

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline
chrisronline merged commit dfac5d8 into elastic:master Jan 9, 2020
@chrisronline
chrisronline deleted the monitoring/setup_mode_ccs branch January 9, 2020 18:14
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 9, 2020
* Ensure setup mode work in a ccs environment

* Missed this file
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 9, 2020
* Ensure setup mode work in a ccs environment

* Missed this file
chrisronline added a commit that referenced this pull request Jan 9, 2020
…4381)

* Ensure setup mode work in a ccs environment

* Missed this file
@chrisronline

chrisronline commented Jan 9, 2020 •

Copy link
Copy Markdown
Contributor Author

Backport:

7.x: ace1893
7.5: 195508d

chrisronline added a commit that referenced this pull request Jan 9, 2020
…4380)

* Ensure setup mode work in a ccs environment

* Missed this file
dgieselaar pushed a commit to ogupte/kibana that referenced this pull request Jan 10, 2020
* Ensure setup mode work in a ccs environment

* Missed this file
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* Ensure setup mode work in a ccs environment

* Missed this file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Monitoring] Setup mode doesn't work in a CCS environment

4 participants