Skip to content

[Uptime] Fix Date Range picker stop refresh button - #55499

Merged
shahzad31 merged 3 commits into
elastic:masterfrom
shahzad31:fix/super-date-picker-refresh-pause
Jan 24, 2020
Merged

[Uptime] Fix Date Range picker stop refresh button#55499
shahzad31 merged 3 commits into
elastic:masterfrom
shahzad31:fix/super-date-picker-refresh-pause

Conversation

@shahzad31

@shahzad31 shahzad31 commented Jan 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fix #55498

There was a typo in code which is fixed now.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@shahzad31 shahzad31 self-assigned this Jan 22, 2020
@shahzad31 shahzad31 added v7.6.0 v7.7.0 v8.0.0 release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 22, 2020
@elasticmachine

elasticmachine commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
shahzad31 requested a review from andrewvc January 22, 2020 00:48
justinkambic
justinkambic approved these changes Jan 23, 2020
View reviewed changes

@justinkambic justinkambic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31

shahzad31 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

@andrewvc @justinkambic This typo is also present in 7.5, should we backport it there as well?

@shahzad31

shahzad31 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@shahzad31

shahzad31 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine

kibanamachine commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31
shahzad31 merged commit 6beb2b2 into elastic:master Jan 24, 2020
@shahzad31
shahzad31 deleted the fix/super-date-picker-refresh-pause branch January 24, 2020 12:47
This was referenced Jan 24, 2020
Merged
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jan 24, 2020
@shahzad31 @elasticmachine
fix refresh pause (elastic#55499)
e92a27b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Jan 24, 2020
@shahzad31 @elasticmachine
fix refresh pause (#55499) (#55839)
0b6701e 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Jan 24, 2020
@shahzad31 @elasticmachine
fix refresh pause (#55499) (#55838)
a0d11e9 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@shahzad31 @elasticmachine
fix refresh pause (elastic#55499)
5411df1 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinkambic justinkambic justinkambic approved these changes
@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees

@shahzad31 shahzad31

Labels

release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Super Date Range Picker Refresh pause is broken

4 participants

@shahzad31 @elasticmachine @kibanamachine @justinkambic