Repository navigation
[Logs UI] Allow Logs/ML integration result access with machine… - #55884
weltenwort merged 7 commits into
Conversation
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
| import { FormattedMessage } from '@kbn/i18n/react'; | ||
| import React from 'react'; | ||
|
|
||
| export const UserManagementLink: React.FunctionComponent<EuiButtonProps> = props => ( |
There was a problem hiding this comment.
Should this render if the user doesn't have permissions to manage the users?
There was a problem hiding this comment.
Well, the target page exists and gives actionable advice. 🤔 Is that too bad of a UX? @katrin-freihofner what do you think?
There was a problem hiding this comment.
First of all, I'm confused about the machine_learning_user role - why do we need this role? Second, I think the message proposed in this PR is good. Where does the button Manage users link to?
There was a problem hiding this comment.
The role is required to be able to check the status of ML jobs and to access their results.
The button links to the user management section in Kibana. That is what @afgomez took the screenshot of above.
There was a problem hiding this comment.
Before this PR we required the machine_learning_admin role even to read the results, which made it barely usable for sensible Elasticsearch deployments.
There was a problem hiding this comment.
Ok, I understand. One more question: does it make sense that we take the user to the user management screen? Are there any actions they can take? If not, I'd rather display this in the Additional ML privileges required message and remove the button.
There was a problem hiding this comment.
That screen allows the user to assign the role if they have the permission. I thought a call to action would be preferable. I can remove the button, though.
There was a problem hiding this comment.
I'll merge this fix for now to get into a BC. We can tweak the UX in follow-up PRs.
…tic#55884) This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the `machine_learning_admin` role.
…tic#55884) This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the `machine_learning_admin` role.
Backports the following commits to 7.x: - [Logs UI] Allow Logs/ML integration result access with machine… (#55884)
…tic#55884) This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the `machine_learning_admin` role.
Summary
This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the
machine_learning_adminrole.If the user doesn't have any ML role the following message is shown:
If the user doesn't have the
machine_learning_adminrole but the ML job needs to be set up, the following message is shown:If the user has either of the
machine_learning_adminormachine_learning_userroles and the job has already been set up, the results screen is show.fixes #55843
Testing notes
The following combinations of user role and setup status would be relevant:
machine_learning_adminmachine_learning_userWhere "setup info" means a message that informs about privileges required for setting up jobs and "results info" means a message that informs about privileges required for status and results.
Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenarios(will be handled in a follow-up PR)