Repository navigation
[7.6.1] [Lens] Fix bugs in Lens filters (#56441) - #56648
Merged
Merged
Conversation
* [Lens] Fix bug where filters were not displayed * Fix elastic#55603 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Dosant
reviewed
Feb 5, 2020
Contributor
Author
|
Sorry, haven't actually fixed the issues yet |
Contributor
Author
|
Figured out the issue: filterManager was making a copy of |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow editing saved visualizationsStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests "after all" hook for "should allow creation of lens visualizations"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens.lens app "after all" hook in ""Standard OutStack Traceand 7 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security·ts.dashboard feature controls dashboard security global dashboard all privileges, no embeddable application privileges landing page shows "Create new Dashboard" buttonStandard OutStack TraceKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/lens/public/app_plugin.Lens App renders the editor frameStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Feb 7, 2020
Dosant
left a comment
Contributor
There was a problem hiding this comment.
Code lgtm
Tested that only pinned filters are preserved when navigating to lens and that global filters saved with lens vis are not shown on UI.
lizozom
reviewed
Feb 9, 2020
| }} | ||
| onSavedQueryUpdated={savedQuery => { | ||
| data.query.filterManager.setFilters(savedQuery.attributes.filters || state.filters); | ||
| data.query.filterManager.setFilters(savedQuery.attributes.filters || []); |
Contributor
There was a problem hiding this comment.
Great as a fix for 7.6.1, but consider using #56160 for 7.7 to avoid similar issues 🙏
Contributor
Author
There was a problem hiding this comment.
The fix using that code is already in 7.7, but I couldn't backport it to 7.6
mbondyra
reviewed
Feb 13, 2020
| const field = ({ name: 'myfield' } as unknown) as IFieldType; | ||
|
|
||
| args.data.query.filterManager.setFilters([esFilters.buildExistsFilter(field, indexPattern)]); | ||
| const filter = { |
Contributor
There was a problem hiding this comment.
Nitpick: Not sure if it's valuable (treat this comment as learning opportunity for me :D ) but in the query tests below we construct filters using setting Filter Store:
const unpinned = esFilters.buildExistsFilter(field, indexPattern);
FilterManager.setFiltersStore([unpinned], esFilters.FilterStateStore.APP_STATE);
while here you construct the filter object. Maybe it's worth to unify it?
Contributor
Author
There was a problem hiding this comment.
I looked into this a bit more and specifically the exists filter has a different type definition than the other types. This is definitely worth highlighting to so I'm building the filters manually!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit started as a backport of [Lens] Fix bugs in Lens filters (#56441), but is no longer a strict backport because
setAppFiltersin the FilterManager code was added in #55158 which is not going into 7.6