Repository navigation
Rollup index pattern error: must match one rollup index - #56732
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
marked this pull request as ready for review
February 4, 2020 13:05
Contributor
|
@alexwizp Thank you for the ping, but I don't think I'm the best person to review this code. Because this falls under @elastic/kibana-app or @elastic/kibana-app-arch I am going to take myself off the list of reviewers and let someone from one of those teams review. |
cjcenizal
removed their request for review
February 4, 2020 20:27
Contributor
Author
|
@elasticmachine merge upstream |
flash1293
requested review from
alisonelizabeth
and removed request for
alisonelizabeth
February 5, 2020 09:22
Contributor
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@flash1293 Looks like this PR also fixes #55807 |
flash1293
approved these changes
Feb 5, 2020
flash1293
left a comment
Contributor
There was a problem hiding this comment.
Tested and works. Thanks for fixing two bugs at once!
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 5, 2020
Closes: elastic#32765 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Feb 5, 2020
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
Closes: elastic#32765 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #32765
Summary
Steps to reproduce:
Stack Managementpage and navigate toElasticsearch -> Rollup Jobs;rollup-game-of-thronesbygame-of-thronesindex pattern);1minterval/delay to reduce time of indexing).Open Kibana -> Index patterns;Important: please don't refresh page after step
#1 (Creating a new Rollup Job)Rollup Index Pattern:Rollup IndexinIndex Patternfield;Expected Result:
Next Stepbutton should be enabledIndex Patternshould be valid. No error messagesRoot cause analysis:
I found a problem in the
RollupIndexPatternCreationConfigclass. We are currently creating a new instance of this class only from theaddmethod inIndexPatternCreationManager. This happens only once during a user session, because now we call it from thesetuphook of rollup plugin, seesrc/legacy/core_plugins/management/public/np_ready/plugin.ts.Now let's return back to
/rollup_index_pattern_creation_config.jsfile and go to constructor function. Here we run the asynchronous methodsetRollupIndices, which was supposed to fill the internal fields ofrollupIndicesCapabilitiesandrollupIndices. It happens only once and if the user created a new Rollup Index without refreshing the page, it is not available.@cjcenizal I've moved setRollupIndices into getIndexPatternCreationOption method and looks like now all works fine. But I think instead of using constructor for IndexPatternCreationConfig we should implement 2 additional setup/start methods in future.
Checklist
For maintainers