Repository navigation
[ML] Global calendars - #57890
Merged
jgowdyelastic merged 5 commits intoFeb 25, 2020
Merged
[ML] Global calendars#57890
Conversation
jgowdyelastic
force-pushed
the
adding-global-calendars
branch
2 times, most recently
from
February 20, 2020 16:05
3ffca45 to
8c1e04f
Compare
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
February 20, 2020 16:06
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
marked this pull request as ready for review
February 20, 2020 16:06
jgowdyelastic
force-pushed
the
adding-global-calendars
branch
from
February 24, 2020 08:32
8c1e04f to
898b6e1
Compare
jgowdyelastic
force-pushed
the
adding-global-calendars
branch
from
February 24, 2020 18:04
898b6e1 to
00c480d
Compare
peteharverson
approved these changes
Feb 25, 2020
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
One more suggestion for the form layout! But otherwise LGTM.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 25, 2020
* [ML] Global calendars * updating snapshots * changes based on review * larger spacer * updating jest snapshot
jgowdyelastic
added a commit
that referenced
this pull request
Feb 25, 2020
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [ML] Global calendars * updating snapshots * changes based on review * larger spacer * updating jest snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI work for global calendars elastic/elasticsearch#50372
Fixes #53604
A checkbox has been added to the new and edit calendar form to mark the calendar as "global".
This adds a single job id of
_allto the calendar._allis then seen as a group id because it is in a calendar and is not an existing job id and so needs to be filtered out of all group selections.Any global calendars (i.e. containing
_allare not selectable in the new job wizards)Checklist
Delete any items that are not applicable to this PR.
For maintainers