Repository navigation
[APM] Use ES Permission API to check if a user has permissions to read from APM indices - #57311
Merged
Merged
Conversation
sorenlouv
reviewed
Feb 11, 2020
sorenlouv
reviewed
Feb 11, 2020
sorenlouv
reviewed
Feb 11, 2020
sorenlouv
reviewed
Feb 11, 2020
cauemarcondes
commented
Feb 11, 2020
sorenlouv
reviewed
Feb 11, 2020
cauemarcondes
commented
Feb 12, 2020
cauemarcondes
force-pushed
the
missing-permission
branch
from
February 13, 2020 09:11
5126d03 to
b8aac58
Compare
cauemarcondes
marked this pull request as ready for review
February 13, 2020 10:06
sorenlouv
reviewed
Feb 14, 2020
sorenlouv
reviewed
Feb 14, 2020
sorenlouv
reviewed
Feb 14, 2020
sorenlouv
reviewed
Feb 14, 2020
sorenlouv
approved these changes
Feb 14, 2020
sorenlouv
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a few few copy changes
Contributor
Author
|
@elasticmachine merge upstream |
sorenlouv
approved these changes
Feb 17, 2020
Contributor
Author
|
retest |
cauemarcondes
force-pushed
the
missing-permission
branch
from
February 19, 2020 08:00
9f3b384 to
a14e9ca
Compare
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Feb 19, 2020
…d from APM indices (elastic#57311) * get indices privileges from has_privileges api * changing to ES privileges api * changing missing permission page * always show dimiss button * always show dimiss button * changing message and unit test * fixing react warning message
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…d from APM indices (elastic#57311) * get indices privileges from has_privileges api * changing to ES privileges api * changing missing permission page * always show dimiss button * always show dimiss button * changing message and unit test * fixing react warning message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #57215
Server route:
/api/apm/security/indices_privilegesI renamed all server-side from 'Permissions' to 'Privileges', since I'm going to return all privileges from APM indices. And in the client, I'll check if the user has permission based on the privileges.