Repository navigation
[Metrics UI] Custom Metrics for Inventory View - #58072
Merged
simianhacker merged 16 commits intoFeb 26, 2020
Merged
Conversation
…w-custom-metrics-np
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
…w-custom-metrics-np
simianhacker
marked this pull request as ready for review
February 21, 2020 14:54
|
Looks good! Also +1 for implementing it in a way that persists custom metrics in a saved view. |
…w-custom-metrics-np
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 26, 2020
* [Metrics UI] Add custom metrics interface to Inventory View * WIP * Adding workflows for editing custom metrics * Polishing visual design * Removing extra text * Fixing types and return values * fixing i18n * Adding aria labels for clearity * Changing custom group by to match same width as custom metric * updating integration test for custom metrics * Fixing type def
simianhacker
added a commit
that referenced
this pull request
Feb 26, 2020
* [Metrics UI] Add custom metrics interface to Inventory View * WIP * Adding workflows for editing custom metrics * Polishing visual design * Removing extra text * Fixing types and return values * fixing i18n * Adding aria labels for clearity * Changing custom group by to match same width as custom metric * updating integration test for custom metrics * Fixing type def
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [Metrics UI] Add custom metrics interface to Inventory View * WIP * Adding workflows for editing custom metrics * Polishing visual design * Removing extra text * Fixing types and return values * fixing i18n * Adding aria labels for clearity * Changing custom group by to match same width as custom metric * updating integration test for custom metrics * Fixing type def
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #50193 by adding a custom metric option to the metrics pull down in the Inventory view. This features:
This PR also fixes #35006 by widening the custom grouping form and field to be the same width as the custom metrics form.
Screencast
The custom metrics behavior
Screen Shots
The custom group width matches the custom metrics.
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenarios