Skip to content

Skip CI based on changes in PR - #59939

Merged
brianseeders merged 10 commits into
elastic:masterfrom
brianseeders:skip-ci
Mar 12, 2020
Merged

brianseeders merged 10 commits into
elastic:masterfrom
brianseeders:skip-ci

Conversation

@brianseeders

@brianseeders brianseeders commented Mar 11, 2020 •

Copy link
Copy Markdown
Contributor

For PRs that don't require CI, such as changes to docs only, skip CI altogether.

Uses the GitHub API to check the PR for changes. The API returns up to 3000 changes.

If the API returns 3000 changes, CI will always run.
If the API returns an error (or some other error happens related to checking), it will be logged to the console, and CI will run.

Both previous and new filenames are considered for renamed files when looking at changes.

@brianseeders brianseeders added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 11, 2020
@brianseeders

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

1 similar comment
@brianseeders

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@brianseeders

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@brianseeders brianseeders added v7.6.2 v7.7.0 Feature:CI Continuous integration Team:Operations Kibana-Operations Team labels Mar 11, 2020
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@brianseeders
brianseeders marked this pull request as ready for review March 11, 2020 21:15
@brianseeders brianseeders changed the title Playing around with skipping CI based on changes in PR Skipping CI based on changes in PR Mar 11, 2020
@brianseeders brianseeders changed the title Skipping CI based on changes in PR Skip CI based on changes in PR Mar 11, 2020
@brianseeders
brianseeders requested a review from a team March 11, 2020 21:36

@spalger spalger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I guess the real test will have to wait until we merge this and merge master into a docs only PR?

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders

Copy link
Copy Markdown
Contributor Author

LGTM, though I guess the real test will have to wait until we merge this and merge master into a docs only PR?

I did do a test with examples of all of the skippable paths, and it did indeed skip: df3520a

@brianseeders
brianseeders merged commit 8d19fb0 into elastic:master Mar 12, 2020
@brianseeders
brianseeders deleted the skip-ci branch March 12, 2020 15:07
brianseeders added a commit to brianseeders/kibana that referenced this pull request Mar 12, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Mar 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
* master: (45 commits)
  skip flaky suite (elastic#59717)
  UI Metrics use findAll to retrieve all Saved Objects (elastic#59891)
  [Discover] Migrate Context mocha tests to use Jest (elastic#59658)
  [Maps] Move redux reducers and store logic to NP (elastic#58294)
  rebalance x-pack groups (elastic#58930)
  [Discover] Reimplement $route.reload when index pattern changes (elastic#59877)
  [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745)
  Skip CI based on changes in PR (elastic#59939)
  [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723)
  [ML] Functional tests - stabilize date_nanos test (elastic#59986)
  [ML] Typescripting client side endpoint functions (elastic#59928)
  a11y tests on adding columns to discover table (elastic#59375)
  fix graph plugin config path (elastic#59540)
  fix vega config issues (elastic#59737)
  [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890)
  [ML] Adding shared services to ml setup contract (elastic#59730)
  [Visualize] Fix linked search behavior (elastic#59690)
  [ML] Register NP ML plugin for Kibana management section. (elastic#59762)
  [Lens] Adds using queries/filters for field existence endpoint (elastic#59033)
  Delete FilterStateManager and QueryFilter :-D (elastic#59872)
  ...
@spalger

spalger commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

🕺🕺🕺

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.6.2 v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants