Skip to content

Edits UI text for ML nodes and job button #60184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcawl merged 6 commits into from
Mar 18, 2020
Merged

Edits UI text for ML nodes and job button #60184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddba101
Edits UI text for ML nodes and job button
lcawl Mar 14, 2020
1f5c2af
Merge branch 'master' into ml-job-mgmt
elasticmachine Mar 16, 2020
ae0d59c
Merge branch 'master' into ml-job-mgmt
elasticmachine Mar 16, 2020
48846b2
Merge branch 'master' into ml-job-mgmt
elasticmachine Mar 17, 2020
bfa7425
Update x-pack/plugins/ml/public/application/explorer/components/explo…
lcawl Mar 17, 2020
d7e1d54
Update x-pack/plugins/ml/public/application/explorer/components/explo…
lcawl Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...m/public/components/app/ServiceDetails/ServiceIntegrations/MachineLearningFlyout/view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export function MachineLearningFlyoutView({
{i18n.translate(
'xpack.apm.serviceDetails.enableAnomalyDetectionPanel.createNewJobButtonLabel',
{
defaultMessage: 'Create new job'
defaultMessage: 'Create job'
}
)}
</EuiButton>
Expand Down
2 changes: 1 addition & 1 deletion ...lorer/components/explorer_no_jobs_found/__snapshots__/explorer_no_jobs_found.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions ...l/public/application/explorer/components/explorer_no_jobs_found/explorer_no_jobs_found.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ export const ExplorerNoJobsFound = () => (
}
actions={
<EuiButton color="primary" fill href="ml#/jobs">
<FormattedMessage
id="xpack.ml.explorer.createNewJobLinkText"
defaultMessage="Create new job"
/>
<FormattedMessage id="xpack.ml.explorer.createNewJobLinkText" defaultMessage="Create job" />
</EuiButton>
}
data-test-subj="mlNoJobsFound"
Expand Down
2 changes: 1 addition & 1 deletion .../plugins/ml/public/application/jobs/jobs_list/components/jobs_stats_bar/jobs_stats_bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function createJobStats(jobsSummaryList) {
const jobStats = {
activeNodes: {
label: i18n.translate('xpack.ml.jobsList.statsBar.activeMLNodesLabel', {
defaultMessage: 'Active ML Nodes',
defaultMessage: 'Active ML nodes',
}),
value: 0,
show: true,
Expand Down
2 changes: 1 addition & 1 deletion .../plugins/ml/public/application/jobs/jobs_list/components/new_job_button/new_job_button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function NewJobButton() {
>
<FormattedMessage
id="xpack.ml.jobsList.createNewJobButtonLabel"
defaultMessage="Create new job"
defaultMessage="Create job"
/>
</EuiButton>
);
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function getStatsBarData(jobsList: any) {
const jobStats = {
activeNodes: {
label: i18n.translate('xpack.ml.overviewJobsList.statsBar.activeMLNodesLabel', {
defaultMessage: 'Active ML Nodes',
defaultMessage: 'Active ML nodes',
}),
value: 0,
show: true,
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/services/job_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class JobService {
this.jobStats = {
activeNodes: {
label: i18n.translate('xpack.ml.jobService.activeMLNodesLabel', {
defaultMessage: 'Active ML Nodes',
defaultMessage: 'Active ML nodes',
}),
value: 0,
show: true,
Expand Down