Skip to content

Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_actions plugin - #60202

Merged
spalger merged 9 commits into
elastic:masterfrom
mattkime:move_triggers
Mar 15, 2020
Merged

spalger merged 9 commits into
elastic:masterfrom
mattkime:move_triggers

Conversation

@mattkime

@mattkime mattkime commented Mar 14, 2020 •

Copy link
Copy Markdown
Contributor

Summary

Moves triggers to ui_actions to prevent flakey test failures. Follow up to #60168

Fixed #60148

@mattkime
mattkime requested a review from a team March 14, 2020 17:14
@mattkime
mattkime requested a review from a team as a code owner March 14, 2020 17:14
@mattkime mattkime added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.7.0 Team:AppArch labels Mar 14, 2020
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elastic elastic deleted a comment from kibanamachine Mar 14, 2020
@mattkime
mattkime requested a review from a team as a code owner March 14, 2020 23:38
@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@spalger spalger left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm going to run the tests on this a handful of times and if they all pass I might merge this without all the required review as master is pretty flaky right now.

@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@timroes timroes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana App code LGTM

@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@spalger
spalger merged commit 7e36950 into elastic:master Mar 15, 2020
@spalger

spalger commented Mar 15, 2020 •

Copy link
Copy Markdown
Contributor

Five successes makes me happy, though I'd prefer to have more review. The changes seem simple though and, more importantly, totally functional.

spalger pushed a commit to spalger/kibana that referenced this pull request Mar 15, 2020
…tic#60202)

* move triggers

* move triggers

* fix import path

* fix import path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Mar 15, 2020
@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger

spalger commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

7.7/7.x: a6f2b2e

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
…o alerting/view-in-app

* 'alerting/view-in-app' of github.com:gmmorris/kibana: (33 commits)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  [SIEM] [Case] Insert timeline bugfix and limit 25 cases (elastic#60136)
  [ML] Client side cut over (elastic#60100)
  Disable query bar on service map routes (elastic#60118)
  Move subscribe_with_scope to kibana_legacy (elastic#59781)
  [Ingest] Agent Config create with sys monitoring (elastic#60111)
  [Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot (elastic#59383)
  Actually fetch functionbeat fields needed for telemetry (elastic#60054)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
* master: (40 commits)
  skips 'config_open.ts' files from linter check (elastic#60248)
  [Searchprofiler] Spacing between rendered shards (elastic#60238)
  Add UiSettings validation & Kibana default route redirection (elastic#59694)
  [SIEM][CASE] Change configuration button (elastic#60229)
  [Step 1][App Arch] Saved object migrations from kibana plugin to new platform  (elastic#59044)
  adds new test (elastic#60064)
  [Uptime] Index Status API to Rest (elastic#59657)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  ...
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
…tic#60202)

* move triggers

* move triggers

* fix import path

* fix import path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[uiActions] VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER should be registered by uiActions plugin.

5 participants