Repository navigation
[Canvas] Fix embeddables not showing up on PDF reports - #61149
Merged
poffdeluxe merged 3 commits intoMar 25, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
Author
|
@elasticmachine merge upstream |
poffdeluxe
commented
Mar 24, 2020
| {Style.it( | ||
| workpad.css, | ||
| <div className="canvasExport__stageContent"> | ||
| <div className="canvasExport__stageContent" data-shared-items-count={pageElementCount}> |
Contributor
Author
There was a problem hiding this comment.
This tells reporting how many elements it should expect on the page. Since the embeddables aren't loaded immediately sometimes, we need to tell reporting to wait and expect them to become available
poffdeluxe
added a commit
that referenced
this pull request
Mar 25, 2020
…61345) * Allow embeddables to track their own render complete for report generation in canvas * Updating following consult with reporting team Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
This fix was originally intended for v7.7.0 but it got merged into 7.x after the original 7.7 branch was cut so it unfortunately missed it. I'm backporting it into 7.7 now so it can make it into 7.7.2 |
poffdeluxe
added a commit
that referenced
this pull request
Jun 4, 2020
…68268) * Allow embeddables to track their own render complete for report generation in canvas * Updating following consult with reporting team Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/legacy/plugins/canvas/public/apps/export/export/export_app.js
Contributor
💔 Build Failed
Failed CI Steps
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…1149) * Allow embeddables to track their own render complete for report generation in canvas * Updating following consult with reporting team Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canvas was setting the
data-render-completeattribute to true on embeddables before they had fully rendered. Embeddables should be in charge of setting their owndata-render-completesetting so Canvas does not need to set the attribute.Fixes #60655