Repository navigation
[ML] Data Visualizer, Explorer, Transform wizard: Ensure query bar syntax errors are shown - #61333
Merged
alvarezmelissa87 merged 7 commits intoMar 26, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
This looks good, apart from a minor text edit. But could you extend this fix to the index data visualizer query bar, and the one in the Transforms wizard too?
Contributor
There was a problem hiding this comment.
Should use sentence case here Invalid query
alvarezmelissa87
force-pushed
the
ml-kql-removal
branch
from
March 26, 2020 13:46
cf4f31e to
5c29f10
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Mar 26, 2020
…ntax errors are shown (elastic#61333) * remove deprecated kqlFilterBar dir * remove unused explorer code * show syntax error message below query input * remove unused translations * syntax error message for datavisualizer * add syntax error handling to transform wizard * fix translation label
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Mar 26, 2020
…ntax errors are shown (elastic#61333) * remove deprecated kqlFilterBar dir * remove unused explorer code * show syntax error message below query input * remove unused translations * syntax error message for datavisualizer * add syntax error handling to transform wizard * fix translation label
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…ntax errors are shown (elastic#61333) * remove deprecated kqlFilterBar dir * remove unused explorer code * show syntax error message below query input * remove unused translations * syntax error message for datavisualizer * add syntax error handling to transform wizard * fix translation label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to KqlFilterBar replacement in explorer (#60451)
kql_filter_barcustom component that is now unusedChecklist
Delete any items that are not applicable to this PR.