Repository navigation
[SIEM] [CASES] bug/clean up phase I - #61354
Merged
Merged
Conversation
…ed/updated + return all comments
…with pushed data + fix three dot on detail page
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
22 of 26 tasks
| interface PatchComment { | ||
| commentId: string; | ||
| updatedAttributes: Partial<CommentAttributes & PushedArgs>; | ||
| updatedAttributes: Partial<CommentAttributes>; |
Contributor
Author
There was a problem hiding this comment.
I think we can update any CommentAttributes or do i miss something?
| [hasDataToPush, isLoading, theCase.externalService] | ||
| ); | ||
| const handleRenderDataToPush = useCallback(() => { | ||
| const lastCaseUpdate = theCase.updatedAt != null ? new Date(theCase.updatedAt) : null; |
Contributor
There was a problem hiding this comment.
this is the same logic as in use_post_push_to_service.tsx. can we lift it into a util file?
Contributor
Author
There was a problem hiding this comment.
it is not because one is using CaseUserActions and the other one is using the data in case from the attributes external service
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
| }); | ||
|
|
||
| it(`Error if you passing status for a new case`, async () => { | ||
| const request = httpServerMock.createKibanaRequest({ |
stephmilovic
approved these changes
Mar 26, 2020
stephmilovic
left a comment
Contributor
There was a problem hiding this comment.
code review ✅
endpoint testing ✅
manual testing ✅
unit testing ✅
LGTM, thanks @XavierM 🚀 🎸
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Mar 27, 2020
* clean up comments + add update_by/update_at case when comment are added/updated + return all comments * add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page * fix i18m * review I * review II
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Mar 27, 2020
* clean up comments + add update_by/update_at case when comment are added/updated + return all comments * add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page * fix i18m * review I * review II
XavierM
added a commit
that referenced
this pull request
Mar 27, 2020
* clean up comments + add update_by/update_at case when comment are added/updated + return all comments * add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page * fix i18m * review I * review II
XavierM
added a commit
that referenced
this pull request
Mar 27, 2020
* clean up comments + add update_by/update_at case when comment are added/updated + return all comments * add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page * fix i18m * review I * review II
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* clean up comments + add update_by/update_at case when comment are added/updated + return all comments * add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page * fix i18m * review I * review II
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary