Repository navigation
[7.7] Fix disabled switches in the editor - #62911
Conversation
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream. |
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and the switches are disabled in the expected scenarios, LGTM. Unsure about the !(isType('number')(props.agg) || isType('date')(props.agg)) case for extended bounds - isn't this just a histogram thing?
| @@ -44,7 +45,6 @@ function HasExtendedBoundsParamEditor(props: AggParamEditorProps<boolean>) { | |||
| !props.agg.params.min_doc_count || | |||
| !(isType('number')(props.agg) || isType('date')(props.agg)) | |||
There was a problem hiding this comment.
How can I test this case?
There was a problem hiding this comment.
This was just a leftover from legacy (take a look at diff L175 - L185) :
https://github.com/elastic/kibana/pull/34790/files#diff-88777ed0ae47452a0e9d817898c51d51
but yeah, I think this is extra since the field can't be anything than only number type.
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests click on the bar in XYChart adds proper filters/timerangeStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Summary
This fixes disabling switch buttons in the editor.
The root cause is
propshas adisabledparam, so it overlaps the defineddisabled.Appropriate fix for
master/7.xis included in #62475Checklist
Delete any items that are not applicable to this PR.
For maintainers