Repository navigation
[SIEM][Detection Engine] Fixes export of single rule and the icons - #62394
Merged
FrankHassanabad merged 2 commits intoApr 3, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
yctercero
approved these changes
Apr 3, 2020
yctercero
left a comment
Contributor
There was a problem hiding this comment.
LGTM - Pulled down, confirmed icon changes, tried exporting and exports successfully. Thanks for adding all the tests! My only comment would be to maybe add one more test about export being disabled for prepackaged rules.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 3, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes export of single rule and the icons.
rule.idinstead of therule.rule_idwhere now it flips it and works as expected.Icons Before:
Icons After:
Checklist