Skip to content

[SIEM] [Cases] Case container unit tests - #63376

Merged
stephmilovic merged 11 commits into
elastic:masterfrom
stephmilovic:case-container-tests
Apr 14, 2020
Merged

stephmilovic merged 11 commits into
elastic:masterfrom
stephmilovic:case-container-tests

Conversation

@stephmilovic

@stephmilovic stephmilovic commented Apr 13, 2020 •

Copy link
Copy Markdown
Contributor

Summary

Tests all files in the dir siem/public/containers/case. Also consolidated the mock data from case/components into the new mock data in containers/case.
Screen Shot 2020-04-13 at 11 02 43 AM

Me after 2 weeks of writing unit tests:
giphy

Checklist

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 13, 2020
@stephmilovic
stephmilovic requested a review from a team as a code owner April 13, 2020 17:08
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic self-assigned this Apr 13, 2020
Comment thread x-pack/legacy/plugins/siem/public/containers/case/api.test.tsx Outdated
Comment thread x-pack/legacy/plugins/siem/public/containers/case/api.test.tsx
Comment thread x-pack/legacy/plugins/siem/public/containers/case/api.test.tsx
Comment thread x-pack/legacy/plugins/siem/public/containers/case/use_get_action_license.test.tsx Outdated
Comment thread x-pack/legacy/plugins/siem/public/containers/case/use_delete_cases.test.tsx Outdated

@cnasikas cnasikas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic
stephmilovic merged commit d275d7f into elastic:master Apr 14, 2020
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Apr 14, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
* master: (29 commits)
  Add test:jest_integration npm script (elastic#62938)
  [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548)
  [Discover] Fix broken setting of bucketInterval (elastic#62939)
  Disable adding conditions when in alert management context. (elastic#63514)
  [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432)
  adding useMemo (elastic#63504)
  [Maps] fix double fetch when filter pill is added (elastic#63024)
  [Lens] Fix missing formatting bug in "break down by" (elastic#63288)
  [SIEM] [Cases] Removed double pasted line (elastic#63507)
  [Reporting] Improve functional test steps (elastic#63259)
  [SIEM][CASE] Tests for server's configuration API (elastic#63099)
  [SIEM] [Cases] Case container unit tests (elastic#63376)
  [ML] Improving parsing of large uploaded files (elastic#62970)
  [ML] Listing global calendars on the job management page (elastic#63124)
  [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373)
  Add help text to form fields (elastic#63165)
  [ML] Converts utils Mocha tests to Jest (elastic#63132)
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants