Repository navigation
[Security Solution][Detections] Fix "Severity override" dropdowns in "Create new rule" -> "About rule" - #82271
Merged
Conversation
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
peluja1012
approved these changes
Nov 3, 2020
peluja1012
left a comment
Contributor
There was a problem hiding this comment.
Pulled down the branch and played with the UI. It looks good. I like the UX improvement around field suggestions. Now there is more room and users are actually able to see what they're selecting. Thanks Georgii!
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Nov 3, 2020
…"Create new rule" -> "About rule" (elastic#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
banderror
added a commit
that referenced
this pull request
Nov 4, 2020
…"Create new rule" -> "About rule" (#82271) (#82427) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Nov 12, 2020
…"Create new rule" -> "About rule" (elastic#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
This was referenced Nov 12, 2020
banderror
added a commit
that referenced
this pull request
Nov 12, 2020
…"Create new rule" -> "About rule" (#82271) (#83272) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…"Create new rule" -> "About rule" (elastic#82271) We use `EuiComboBox` in all "Severity override" dropdowns (which are called `FieldComponent` and `AutocompleteFieldMatchComponent`). The issue with `EuiComboBox` is that it doesn't handle long text in the placeholder properly. In the elastic#81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #81284
Related PR: elastic/eui#4210
Summary
We use
EuiComboBoxin all "Severity override" dropdowns (which are calledFieldComponentandAutocompleteFieldMatchComponent). The issue withEuiComboBoxis that it doesn't handle long text in the placeholder properly. In the #81284 you can see the placeholders' text being split into multiple lines that gives this messy effect.TODO:
Before
After
Default:
Both overrides checked:
Small screen width:
Now it's enough space to show the whole field name in most cases:
Checklist
Delete any items that are not applicable to this PR.
For maintainers