Repository navigation
[5.x] [kbnUrl] reload the route when going from "" to "/" - #8998
Merged
Merged
Conversation
Backports PR #8815 **Commit 1:** [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * Original sha: a7304ec * Authored by spalger <email@spalger.com> on 2016-10-24T20:43:40Z **Commit 2:** [kbnUrl] clarify the purpose _shouldAutoReload * Original sha: fbfbae3 * Authored by spalger <email@spalger.com> on 2016-10-24T23:45:52Z **Commit 3:** [kbnUrl] fix the tests * Original sha: cc9c2f6 * Authored by spalger <email@spalger.com> on 2016-10-25T00:31:22Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8815 **Commit 1:** [kbnUrl] reload the route when going from "" to "/" In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time. * Original sha: a7304ec * Authored by spalger <email@spalger.com> on 2016-10-24T20:43:40Z **Commit 2:** [kbnUrl] clarify the purpose _shouldAutoReload * Original sha: fbfbae3 * Authored by spalger <email@spalger.com> on 2016-10-24T23:45:52Z **Commit 3:** [kbnUrl] fix the tests * Original sha: cc9c2f6 * Authored by spalger <email@spalger.com> on 2016-10-25T00:31:22Z Former-commit-id: fc8cef7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[kbnUrl] reload the route when going from "" to "/"
Backports PR #8815
Commit 1:
[kbnUrl] reload the route when going from "" to "/"
In timelion the initial route is set to '' which might not be perfectly correct, but works fine. When clicking the "new" button for the first time this causes the route to update from '' to '/', which the kbnUrl service assumes will cause a route change and does not try to force the route to reload. Instead, the router sees this as a noop and the change to the route has no effect unless you click the "new" button a second time.
Commit 2:
[kbnUrl] clarify the purpose _shouldAutoReload
Commit 3:
[kbnUrl] fix the tests