[ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar. by walterra · Pull Request #93956 · elastic/kibana

walterra · 2021-03-08T16:11:56Z

Summary

Adds a Kibana API endpoint transforms/_nodes
Adds number of nodes to the stats bar in the transforms list.
Shows a callout when no transform nodes are available.
Disable all actions except delete when no transform nodes are available.
Disables the create button when no transform nodes are available. e970178

To test this, add the following to elasticsearch.yml of your single node cluster (that's the default node roles taken from here and the transform role commented out):

node.roles: [
  master,
  data,
  data_content,
  data_hot,
  data_warm,
  data_cold,
  ingest,
  ml,
  remote_cluster_client,
  # transform
]

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-03-09T16:38:30Z

Pinging @elastic/ml-ui (:ml)

afharo

Unblocking Core's CODEOWNERS review

qn895 · 2021-03-10T00:00:39Z

+        });
+
+        let count = 0;
+        if (typeof body.nodes === 'object') {


Would this ever be null?

Ah yes, I copied that over from older ML code. Updated in bc3e236.

…e tweak.

walterra · 2021-03-10T08:28:53Z

Update in bc3e236:

API integration test
Improved the initial loading behavior for the stats bar and transform list
Fixed types for the API endpoint

jgowdyelastic · 2021-03-11T17:40:22Z

+        isPopulatedObject(node) &&
+        {}.hasOwnProperty.call(node, 'attributes') &&
+        isPopulatedObject(node.attributes) &&
+        {}.hasOwnProperty.call(node.attributes, 'transform.node')


i think this check is too strict, transform.node may be missing entirely from one of the nodes, in which case the whole check will fail and count will be returned as 0

Good catch and thinking about multiple nodes! I fixed the type guard and added a unit test in cf49a77.

walterra · 2021-03-15T06:42:46Z

@elasticmachine merge upstream

peteharverson

Tested latest edits and LGTM

walterra · 2021-03-15T14:56:59Z

@elasticmachine merge upstream

jgowdyelastic

LGTM

…ml-transform-nodes

walterra · 2021-03-16T08:43:45Z

The tests caught something I missed: The code was based on the legacy format to identify transform nodes via attributes. I changed it to be based on roles instead in 9a471ee. More details in this ES issue: elastic/elasticsearch#69260 (comment)

kibanamachine · 2021-03-16T10:37:47Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	946.6KB	949.8KB	+3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	432.2KB	432.3KB	+62.0B

History

💔 Build #113096 failed 4675a88
💔 Build #112999 failed a0637d6
💚 Build #112825 succeeded cf49a77
💚 Build #112813 succeeded 9cc9719
💔 Build #112795 failed e970178

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

…porting in stats bar. (elastic#93956) - Adds a Kibana API endpoint transforms/_nodes - Adds number of nodes to the stats bar in the transforms list. - Shows a callout when no transform nodes are available. - Disable all actions except delete when no transform nodes are available. - Disables the create button when no transform nodes are available.

…porting in stats bar. (#93956) (#94677) - Adds a Kibana API endpoint transforms/_nodes - Adds number of nodes to the stats bar in the transforms list. - Shows a callout when no transform nodes are available. - Disable all actions except delete when no transform nodes are available. - Disables the create button when no transform nodes are available.

…porting in stats bar. (elastic#93956) - Adds a Kibana API endpoint transforms/_nodes - Adds number of nodes to the stats bar in the transforms list. - Shows a callout when no transform nodes are available. - Disable all actions except delete when no transform nodes are available. - Disables the create button when no transform nodes are available. # Conflicts: # x-pack/plugins/transform/common/api_schemas/type_guards.ts

…rror reporting in stats bar. (#93956) (#95754) - Adds a Kibana API endpoint transforms/_nodes - Adds number of nodes to the stats bar in the transforms list. - Shows a callout when no transform nodes are available. - Disable all actions except delete when no transform nodes are available. - Disables the create button when no transform nodes are available.

…porting in stats bar. (elastic#93956) - Adds a Kibana API endpoint transforms/_nodes - Adds number of nodes to the stats bar in the transforms list. - Shows a callout when no transform nodes are available. - Disable all actions except delete when no transform nodes are available. - Disables the create button when no transform nodes are available.

[ML] Adds number of transform nodes to stats bar.

c020977

walterra added :ml v8.0.0 Feature:Transforms Transforms v7.13.0 v7.12.1 labels Mar 8, 2021

walterra self-assigned this Mar 8, 2021

[ML] Fix typo.

6808b08

walterra changed the title ~~[ML] Transforms: Adds number of transform nodes to stats bar.~~ [ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar. Mar 8, 2021

walterra added bug Fixes for quality problems that affect the customer experience release_note:fix labels Mar 8, 2021

walterra added 2 commits March 9, 2021 15:18

Merge branch 'master' into ml-transform-nodes

0231ef4

[ML] Add callout when no transform nodes available.

bbe793a

walterra marked this pull request as ready for review March 9, 2021 16:38

walterra requested review from a team as code owners March 9, 2021 16:38

walterra requested review from jgowdyelastic, peteharverson and qn895 March 9, 2021 16:39

afharo approved these changes Mar 9, 2021

View reviewed changes

qn895 reviewed Mar 10, 2021

View reviewed changes

walterra added 2 commits March 10, 2021 07:48

Merge branch 'master' into ml-transform-nodes

8afc547

[ML] Functional Tests. Loading behavior improvements. Server side cod…

bc3e236

…e tweak.

[ML] Rename endpoint to /_nodes.

3bede65

This was referenced Mar 10, 2021

[ML] Increase API integration test coverage #63700

Closed

[ML] Increase Test Coverage 7.13 #93205

Closed

walterra added 2 commits March 10, 2021 11:44

Merge branch 'master' into ml-transform-nodes

c09dbf7

[ML] Update jest test.

f7ff1e7

walterra added 3 commits March 11, 2021 17:41

[ML] Fix type guard.

e5d918c

[ML] Disable create transform button when no transform nodes available.

e970178

[ML] Fix jest test.

9cc9719

jgowdyelastic reviewed Mar 11, 2021

View reviewed changes

[ML] Fix type guard and add jest tests.

cf49a77

Merge branch 'master' into ml-transform-nodes

a0637d6

peteharverson approved these changes Mar 15, 2021

View reviewed changes

Merge branch 'master' into ml-transform-nodes

4675a88

jgowdyelastic approved these changes Mar 15, 2021

View reviewed changes

walterra added 3 commits March 16, 2021 08:43

Merge branch 'master' into ml-transform-nodes

22553c6

[ML] Get number of transform nodes using roles instead of attributes.

9a471ee

Merge branch 'ml-transform-nodes' of github.com:walterra/kibana into …

f8dbbab

…ml-transform-nodes

walterra added the backport pending label Mar 16, 2021

walterra merged commit f3b74b4 into elastic:master Mar 16, 2021

walterra deleted the ml-transform-nodes branch March 16, 2021 10:41

walterra mentioned this pull request Mar 16, 2021

[7.x] [ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar. (#93956) #94677

Merged

walterra mentioned this pull request Mar 30, 2021

[7.12] [ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar. (#93956) #95754

Merged

walterra removed the backport pending label Mar 31, 2021

This was referenced Apr 22, 2021

[ML] Improve error message when transforms are not enabled on any node #74837

Closed

[ML] Transforms: Fix waiting state in transforms list. #98592

Merged

angorayc mentioned this pull request Mar 30, 2023

[SecuritySolution] Check if transform nodes available before enabling risk score modules #154079

Open

Navigation Menu

Repository navigation

[ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar. - #93956

[ML] Transforms: Fixes missing number of transform nodes and error reporting in stats bar.#93956
walterra merged 26 commits into
elastic:masterfrom
walterra:ml-transform-nodes

walterra commented Mar 8, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Mar 9, 2021

Uh oh!

afharo left a comment

Uh oh!

qn895 Mar 10, 2021

Uh oh!

walterra Mar 10, 2021

Uh oh!

walterra commented Mar 10, 2021

Uh oh!

jgowdyelastic Mar 11, 2021

Uh oh!

walterra Mar 11, 2021

Uh oh!

walterra commented Mar 15, 2021

Uh oh!

peteharverson left a comment

Uh oh!

walterra commented Mar 15, 2021

Uh oh!

jgowdyelastic left a comment

Uh oh!

walterra commented Mar 16, 2021

Uh oh!

kibanamachine commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

walterra commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 9, 2021

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

walterra Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

walterra commented Mar 10, 2021

Uh oh!

jgowdyelastic Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

walterra Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

walterra commented Mar 15, 2021

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

walterra commented Mar 15, 2021

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

walterra commented Mar 16, 2021

Uh oh!

kibanamachine commented Mar 16, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

walterra commented Mar 8, 2021 •

edited

Loading