Skip to content

[Logs UI] Tolerate log entries for which fields retrieval fails - #94972

Merged
weltenwort merged 2 commits into
elastic:masterfrom
weltenwort:logs-ui-accept-search-response-without-fields
Mar 24, 2021
Merged

weltenwort merged 2 commits into
elastic:masterfrom
weltenwort:logs-ui-accept-search-response-without-fields

Conversation

@weltenwort

Copy link
Copy Markdown
Member

Summary

This makes the log entry queries more tolerant regarding the lack of the fields property in responses from Elasticsearch. This can happen if the query is executed against a cluster that doesn't support the fields query parameter (via CCS, for example).

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 18, 2021
@weltenwort weltenwort added this to the Logs UI 7.13 milestone Mar 18, 2021
@weltenwort weltenwort self-assigned this Mar 18, 2021
@weltenwort

Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@weltenwort
weltenwort marked this pull request as ready for review March 23, 2021 16:10
@weltenwort
weltenwort requested a review from a team as a code owner March 23, 2021 16:10
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@Kerry350
Kerry350 self-requested a review March 24, 2021 09:44

@Kerry350 Kerry350 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Backport successful

✅ 7.12 / #95317
✅ 7.x / #95318

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 24, 2021
…) (#95317)

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Mar 24, 2021
…) (#95318)

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.1 v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants