Skip to content

Fix positioning of space name and avatar in selector dropdown - #94169

Merged
legrego merged 1 commit into
elastic:masterfrom
legrego:spaces/menu-selector-alignment
Mar 9, 2021
Merged

legrego merged 1 commit into
elastic:masterfrom
legrego:spaces/menu-selector-alignment

Conversation

@legrego

@legrego legrego commented Mar 9, 2021

Copy link
Copy Markdown
Member

Summary

Fixes the positioning of the space name and avatar in the dropdown selector. A recent update (EUI?) caused the contents to be squished together.

Before

CleanShot 2021-03-09 at 13 31 58@2x

After

CleanShot 2021-03-09 at 13 31 38@2x

@legrego legrego added release_note:fix Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:Security/Spaces Platform Security - Spaces feature v8.0.0 v7.13.0 labels Mar 9, 2021
@legrego
legrego requested review from a team as code owners March 9, 2021 18:35
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego added the v7.12.1 label Mar 9, 2021
@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 309.3KB 309.6KB +304.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM!

@legrego legrego added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 9, 2021
@legrego
legrego merged commit d2b9caa into elastic:master Mar 9, 2021
@legrego
legrego deleted the spaces/menu-selector-alignment branch March 9, 2021 22:42
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 9, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 9, 2021
@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Backport successful

✅ 7.12 / #94229
✅ 7.x / #94230

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 10, 2021
#94230)

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 10, 2021
#94229)

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Security/Spaces Platform Security - Spaces feature release_note:fix Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.12.1 v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants