[Swimlane] New integration - #13499

💚 CLA has been signed

I've signed the contributor agreement. Is there a way to re-run that job or is that done automatically?

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Thanks for the feedback @efd6. I'll work on making all these changes.

/test

@kevinmata92, I'm taking over the re-review on this PR from @efd6 for the timebeing.
Looks like the current status of the CI is failing because of errors in pipeline tests (3 places):

pipeline test: test-events.log in swimlane.swimlane_api

test case failed: Expected results are different from actual ones: --- want
+++ got
@@ -28,16 +28,16 @@
             "message": "admin@domain.tld created a new permission",
             "source": {
                 "geo": {
-                    "city_name": "Hale",
+                    "city_name": "London",
                     "continent_name": "Europe",
                     "country_iso_code": "GB",
                     "country_name": "United Kingdom",
                     "location": {
-                        "lat": 51.6261,
-                        "lon": -0.2568
+                        "lat": 51.5142,
+                        "lon": -0.0931
                     },
-                    "region_iso_code": "GB-BNE",
-                    "region_name": "Barnet"
+                    "region_iso_code": "GB-ENG",
+                    "region_name": "England"
                 },
                 "ip": "81.2.69.144"
             },

Similar errors in 2 other places: pipeline test: test-events.log in swimlane.tenant_api, pipeline test: test-events.log in swimlane.turbine_api.
You will need to run pipeline tests using the stack version defined in the manifest.yml kibana.version property which seems to be 8.17.4. Can you run pipeline tests and commit the *-expected.json files?

That should fix the CI issue.

Once that is done, I can do a re-review.

@kcreddy appreciate you helping out, I've ran the test locally against 8.17.4 which we have an it is all passing. Now the odd part is that those files are the same as the ones above.

I ran both elastic-package test and also re-ran elastic-package test pipeline --generate, which did not generate any changes in those files.

--- Test results for package: swimlane - START ---
╭──────────┬──────────────┬───────────┬─────────────────┬────────┬──────────────╮
│ PACKAGE  │ DATA STREAM  │ TEST TYPE │ TEST NAME       │ RESULT │ TIME ELAPSED │
├──────────┼──────────────┼───────────┼─────────────────┼────────┼──────────────┤
│ swimlane │ swimlane_api │ pipeline  │ test-events.log │ PASS   │ 141.711334ms │
│ swimlane │ tenant_api   │ pipeline  │ test-events.log │ PASS   │ 141.237833ms │
│ swimlane │ turbine_api  │ pipeline  │ test-events.log │ PASS   │ 173.962583ms │
╰──────────┴──────────────┴───────────┴─────────────────┴────────┴──────────────╯
--- Test results for package: swimlane - END   ---
Done

Any thoughts on what to try next?

@kevinmata92, that is a bit weird.
I reran the pipeline tests after checking out your PR locally on 8.17.4 stack.
cd packages/swimlane && elastic-package stack down && elastic-package build && elastic-package stack up --version=8.17.4 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v

This produced 3 changes:

Can you try above command and let me know if that works?

Adding the extra line of the test sample logs and that seemed to resolve the issue I was having. I made some additional updates and re-ran elastic-package test and everything passed. Thank you @efd6 @kcreddy for all the help!

/test

/test

/test

💚 Build Succeeded

• Buildkite Build
• Commit: ebb8b23

History

• 💔 Build #25411 failed fe450a9
• 💚 Build #25382 succeeded 6442d80
• 💔 Build #25311 failed 1932b77
• 💚 Build #25240 succeeded 2a39343
• 💚 Build #25178 succeeded f41692f

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Package swimlane - 0.1.0 containing this change is available at https://epr.elastic.co/package/swimlane/0.1.0/

@kcreddy @efd6 Thank you both again for all the immense help on getting this published.

Is there any additional work to do to get this to appear under the integrations page in Elastic? I currently do not see it in our instance unless I am missing something.

Thanks in advance!

@kevinmata92 No, this is done. You can see the package in EPR in the comment above. It is not yet GA (v1+), so to see it in the install integrations page in kibana, you will need to select the toggle to "Display beta integrations".

@efd6 Missed that toggle. Thank you Dan!