Skip to content

[fortinet_fortigate] Handle login events from jsconsole - #14911

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:bug/fortigate_dissect-error
Aug 14, 2025
Merged

taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:bug/fortigate_dissect-error

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Aug 12, 2025 •

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Improve parsing to handle login events from jsconsole

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/fortinet_fortigate
elastic-package test

Related issues

- Improve parsing to handle login events from jsconsole
@taylor-swanson taylor-swanson self-assigned this Aug 12, 2025
@taylor-swanson taylor-swanson added bugfix Pull request that fixes a bug issue Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Aug 12, 2025
@elastic-sonarqube

Copy link
Copy Markdown

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson
taylor-swanson marked this pull request as ready for review August 12, 2025 13:12
@taylor-swanson
taylor-swanson requested a review from a team as a code owner August 12, 2025 13:12
field: error.message
value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}'
description: "Administrator admin logged in successfully from ssh(172.16.200.254)"
description: "Administrator admin logged in successfully from jsconsole|ssh(172.16.200.254)"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to be a description of the processor itself? Current text feels more like a sample message

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to keep the style consistent here, a few of these processors have descriptions like this.

@taylor-swanson
taylor-swanson merged commit fc1720e into elastic:main Aug 14, 2025
@taylor-swanson
taylor-swanson deleted the bug/fortigate_dissect-error branch August 14, 2025 14:01
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package fortinet_fortigate - 1.33.2 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.33.2/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
- Improve parsing to handle login events from jsconsole
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
- Improve parsing to handle login events from jsconsole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fortigate]: Unable to find match for dissect pattern

3 participants