Repository navigation
microsoft_defender_endpoint: add support for oauth endpoint params - #15667
Merged
chemamartinez merged 4 commits intoOct 22, 2025
Merged
chemamartinez merged 4 commits into
chemamartinez merged 4 commits into
Conversation
chemamartinez
marked this pull request as ready for review
October 16, 2025 11:12
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
3012.05 | 2525.25 | -486.8 (-16.16%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
reviewed
Oct 20, 2025
💚 Build Succeeded
History
|
efd6
approved these changes
Oct 21, 2025
chemamartinez
deleted the
15605-mdefender-endpoint-oauth-endpoint-params
branch
October 22, 2025 09:23
Contributor
|
Package microsoft_defender_endpoint - 4.1.0 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/4.1.0/ |
alexreal1314
pushed a commit
to alexreal1314/integrations
that referenced
this pull request
Oct 22, 2025
…lastic#15667) Add support for the oauth_endpoint_params configuration parameter for all available data streams. Log data stream still works under httpjson so the option has been added under data stream level along with all the OAuth2 options for this data stream. For the another data streams, as they work under the CEL input, it has been added at input level so adding any value to this option will affect all data streams that rely on CEL (machine, machine_action, and vulnerability). Finally, the auth logic for the vulnerability data stream is implemented in the CEL program instead of delegate in the CEL auth options for the input. Therefore, the oauth endpoint params in this case are added manually in the program as well.
kcreddy
added a commit
that referenced
this pull request
Oct 30, 2025
…ty response and 403 (#15749) {m365_defender,microsoft_defender_endpoint}.vulnerability: Handle empty response and 403 due to expired URLs. We see cases where the API sends 200 with empty ("") response when fetching vulnerabilities using SAS URLs. Since this errored-URL is not removed from CEL work_list, it leads to following errors every interval: """ failed evaluation: failed eval: ERROR: <input>:2:43: file: EOF | state.?work_list.orValue([]).size() > 0 ? | ..........................................^ """ After a while when the signatures expire (controlled with `sas_valid_hours`), following error is noticed: """ <?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:xxxxxx-xxxx-x-xxx-- Time:2025-10-20T02:07:09.6560520Z</Message><AuthenticationErrorDetail>Signature not valid in the specified key time frame: Key start [Mon, 20 Oct 2025 01:05:29 GMT] - Key expiry [Mon, 20 Oct 2025 02:05:29 GMT] - Current [Mon, 20 Oct 2025 02:07:09 GMT]</AuthenticationErrorDetail></Error> """ Handle both these cases in {m365_defender,microsoft_defender_endpoint}.vulnerability data stream by adding specific error.message asking users to increase "SAS Valid Hours" config option. Add troubleshooting section inside the documentation indicating the same. Also, bring the m365_defender.vulnerability in parity with microsoft_defender_endpoint.vulnerability data stream adding oauth endpoint options from #15667.
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Oct 30, 2025
…lastic#15667) Add support for the oauth_endpoint_params configuration parameter for all available data streams. Log data stream still works under httpjson so the option has been added under data stream level along with all the OAuth2 options for this data stream. For the another data streams, as they work under the CEL input, it has been added at input level so adding any value to this option will affect all data streams that rely on CEL (machine, machine_action, and vulnerability). Finally, the auth logic for the vulnerability data stream is implemented in the CEL program instead of delegate in the CEL auth options for the input. Therefore, the oauth endpoint params in this case are added manually in the program as well.
tehbooom
pushed a commit
to tehbooom/integrations
that referenced
this pull request
Nov 19, 2025
…lastic#15667) Add support for the oauth_endpoint_params configuration parameter for all available data streams. Log data stream still works under httpjson so the option has been added under data stream level along with all the OAuth2 options for this data stream. For the another data streams, as they work under the CEL input, it has been added at input level so adding any value to this option will affect all data streams that rely on CEL (machine, machine_action, and vulnerability). Finally, the auth logic for the vulnerability data stream is implemented in the CEL program instead of delegate in the CEL auth options for the input. Therefore, the oauth endpoint params in this case are added manually in the program as well.
tehbooom
pushed a commit
to tehbooom/integrations
that referenced
this pull request
Nov 19, 2025
…ty response and 403 (elastic#15749) {m365_defender,microsoft_defender_endpoint}.vulnerability: Handle empty response and 403 due to expired URLs. We see cases where the API sends 200 with empty ("") response when fetching vulnerabilities using SAS URLs. Since this errored-URL is not removed from CEL work_list, it leads to following errors every interval: """ failed evaluation: failed eval: ERROR: <input>:2:43: file: EOF | state.?work_list.orValue([]).size() > 0 ? | ..........................................^ """ After a while when the signatures expire (controlled with `sas_valid_hours`), following error is noticed: """ <?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>AuthenticationFailed</Code><Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:xxxxxx-xxxx-x-xxx-- Time:2025-10-20T02:07:09.6560520Z</Message><AuthenticationErrorDetail>Signature not valid in the specified key time frame: Key start [Mon, 20 Oct 2025 01:05:29 GMT] - Key expiry [Mon, 20 Oct 2025 02:05:29 GMT] - Current [Mon, 20 Oct 2025 02:07:09 GMT]</AuthenticationErrorDetail></Error> """ Handle both these cases in {m365_defender,microsoft_defender_endpoint}.vulnerability data stream by adding specific error.message asking users to increase "SAS Valid Hours" config option. Add troubleshooting section inside the documentation indicating the same. Also, bring the m365_defender.vulnerability in parity with microsoft_defender_endpoint.vulnerability data stream adding oauth endpoint options from elastic#15667.
6 tasks done
3 of 4 tasks
6 tasks done
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add support for the
oauth_endpoint_paramsconfiguration parameter for all available data streams.Logdata stream still works under httpjson so the option has been added under data stream level along with all the OAuth2 options for this data stream.For the another data streams, as they work under the CEL input, it has been added at input level so adding any value to this option will affect all data streams that rely on CEL (
machine,machine_action, andvulnerability).Finally, the auth logic for the vulnerability data stream is implemented in the CEL program instead of delegate in the CEL auth options for the input. Therefore, the oauth endpoint params in this case are added manually in the program as well.
Checklist
changelog.ymlfile.Related issues
Screenshots