Skip to content

Expose event_id, and language options to all winlog inputs - #2344

Merged
marc-gr merged 3 commits into
elastic:masterfrom
marc-gr:winlog-language
Dec 16, 2021
Merged

Expose event_id, and language options to all winlog inputs#2344
marc-gr merged 3 commits into
elastic:masterfrom
marc-gr:winlog-language

Conversation

@marc-gr

@marc-gr marc-gr commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Exposes the new language option for all integrations using the winlog input.
  • Exposes event_id for all integrations that didn't let the user customize this option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Dec 15, 2021
@elasticmachine

elasticmachine commented Dec 15, 2021

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine

elasticmachine commented Dec 15, 2021

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Dec 15, 2021 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-15T15:59:52.750+0000

  • Duration: 18 min 16 sec

  • Commit: 7fada81

Test stats 🧪

Test Results
Failed 0
Passed 401
Skipped 0
Total 401

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr
marc-gr merged commit 98889e0 into elastic:master Dec 16, 2021
@marc-gr
marc-gr deleted the winlog-language branch December 16, 2021 12:38
@andrewkroh andrewkroh mentioned this pull request May 11, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
Expose event_id, and language options to all winlog inputs (elastic#2344
9b3fc8e 
)

* Expose event_id, and language options to all winlog inputs

* Add PR to the changelogs

* Fix language description link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @efd6