Skip to content

[aws] Fix http.response.status_code to accept 000 - #3285

Merged
kaiyan-sheng merged 3 commits into
elastic:mainfrom
kaiyan-sheng:cloudfront_logs
May 9, 2022
Merged

[aws] Fix http.response.status_code to accept 000#3285
kaiyan-sheng merged 3 commits into
elastic:mainfrom
kaiyan-sheng:cloudfront_logs

Conversation

@kaiyan-sheng

@kaiyan-sheng kaiyan-sheng commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown

What does this PR do?

Based on AWS docs, in cloudfront logs, sc-status field allows 000 to be one of the acceptable values. With this, we need to change the grok pattern we have when parsing to accept not only positive integers but also just integers.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng
kaiyan-sheng requested a review from a team as a code owner May 5, 2022 16:38
@kaiyan-sheng kaiyan-sheng self-assigned this May 5, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 5, 2022
@elasticmachine

elasticmachine commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-05T20:00:11.288+0000

  • Duration: 28 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.684
Classes 91.667% (11/12) 👎 -4.684
Methods 82.439% (169/205) 👎 -5.67
Lines 92.673% (2087/2252) 👍 3.873
Conditionals 100.0% (0/0) 💚

zmoog
zmoog approved these changes May 9, 2022
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaiyan-sheng
kaiyan-sheng merged commit 6e093be into elastic:main May 9, 2022
@kaiyan-sheng
kaiyan-sheng deleted the cloudfront_logs branch May 9, 2022 17:14
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
kaiyan-sheng
[aws] Fix http.response.status_code to accept 000 (elastic#3285)
cbe76d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes
+1 more reviewer
@andrewkroh andrewkroh andrewkroh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiyan-sheng @elasticmachine @zmoog @andrewkroh