Repository navigation
[kubernetes ] Add missing dimention fields - #4144
Merged
tetianakravchenko merged 2 commits intoSep 7, 2022
Merged
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
jsoriano
approved these changes
Sep 6, 2022
jsoriano
left a comment
Contributor
There was a problem hiding this comment.
I think that at some point we thought that the rest of dimensions were enough to identify resources, specially the ones that have uids, as they should be unique, at least per cluster. But I guess it doesn't do any harm to add this one more dimension. It is true that there are cases where we may not have uids.
gizas
approved these changes
Sep 7, 2022
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* add and fix dimention fields Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * fix pr number; remove dimension for container.name Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co
What does this PR do?
When working on another PR - #4095 (comment), I've noticed that some dimension fields are missing - mainly for
namespacefield - at some point namespace related PR was reverted and all dimension fields were removed - #2209.Also some fields had typos
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots