Skip to content

Enabling kube-state metrics - #4646

Merged
gizas merged 8 commits into
mainfrom
kubestateenable
Nov 15, 2022
Merged

gizas merged 8 commits into
mainfrom
kubestateenable

Conversation

@gizas

@gizas gizas commented Nov 15, 2022 •

Copy link
Copy Markdown
Contributor

Enhancement

What does this PR do?

Enables Kube state metrics by default

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Screenshot 2022-11-15 at 11 51 19 AM

Upgrade to 1.27.2 version and check if kube-state metrics is enabled by default

Related issues

Logs:

Filebeat and Metricbeat started successfully:

{"log.level":"info","@timestamp":"2022-11-15T09:54:20.257Z","log.origin":{"file.name":"stateresolver/stateresolver.go","file.line":49},"message":"Converging state requires execution of 3 step(s)","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-11-15T09:54:21.170Z","log.origin":{"file.name":"log/reporter.go","file.line":40},"message":"2022-11-15T09:54:21Z - message: Application: metricbeat--8.5.0[1a9c4b03-c1ba-458e-9557-8abef159c34f]: State changed to RUNNING: Running - type: 'STATE' - sub_type: 'RUNNING'","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-11-15T09:54:21.267Z","log.origin":{"file.name":"log/reporter.go","file.line":40},"message":"2022-11-15T09:54:21Z - message: Application: filebeat--8.5.0--36643631373035623733363936343635[1a9c4b03-c1ba-458e-9557-8abef159c34f]: State changed to RUNNING: Running - type: 'STATE' - sub_type: 'RUNNING'","ecs.version":"1.6.0"}

When installed kube-state metrics, relevant dataset appeared:

Screenshot 2022-11-15 at 12 10 23 PM

@gizas
gizas requested a review from a team as a code owner November 15, 2022 10:11
Comment thread packages/kubernetes/changelog.yml Outdated
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.27.2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 1.28.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread packages/kubernetes/changelog.yml Outdated
# newer versions go on top
- version: "1.27.2"
changes:
- description: Enabling Kube-state Metrics by default

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep in mind that the reason of having this disabled is to avoid getting errors in case kube-state-metrics is not installed. Is we want to make this quite vocal then that's fine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with message for the banner :)

@elasticmachine

elasticmachine commented Nov 15, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T14:01:52.838+0000

  • Duration: 29 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 15, 2022 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@gizas
gizas merged commit 9f37b3b into main Nov 15, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Adding banner for Kube-state metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Kube-state Metrics dataset in kubernetes Integration by default

4 participants