Skip to content

[Enhancement] [Zscaler ZPA] Make enhancement in connector with best practices implementation - #4648

Merged
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:package-zscaler-zpa-1.4.0
Nov 18, 2022
Merged

[Enhancement] [Zscaler ZPA] Make enhancement in connector with best practices implementation#4648
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:package-zscaler-zpa-1.4.0

Conversation

@vinit-chauhan

@vinit-chauhan vinit-chauhan commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

Make enhancement in Zscaler ZPA connector with listed best practices.

Sr. No. Best Practices
1 Verify best practices test cases are executed
2 Verify all automated tests
3 Verify default values of port for TCP, UDP or HTTP Endpoint Input
4 Verify that the data is ingested in kibana for in interval
5 Verify all fields are correctly mapped for all Data streams
6 Verify related.ip field in datastream
7 Verify network.protocol is in lowercase form
8 Verify with invalid longitude range. [Valid Range : -180 to 180 for longitude]
9 Verify with invalid latitude range. [Valid Range: -90 to 90 for latitude]
10 Verify format of title of dashboard
11 Verify Datastream Dashboard
12 Verify filters in visualizations
13 Verify visualizations in different browser
14 Verify README file

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/zscaler_zpa directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image

@vinit-chauhan
Update Aggregation visualizations to Lens, Add an on_failure processo…
e95662b 
…r to the convert, geo_ip, uri_parts and date processors, and mapped to related ecs field
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner November 15, 2022 11:04
@elasticmachine

elasticmachine commented Nov 15, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Nov 15, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Nov 15, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T11:06:55.588+0000

  • Duration: 18 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 15, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.542
Classes 100.0% (5/5) 💚 2.542
Methods 100.0% (59/59) 💚 9.137
Lines 90.175% (1542/1710) 👎 -1.449
Conditionals 100.0% (0/0) 💚

@P1llus
P1llus merged commit 71c5255 into elastic:main Nov 18, 2022
@vinit-chauhan
vinit-chauhan deleted the package-zscaler-zpa-1.4.0 branch April 1, 2026 23:57
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@vinit-chauhan
[Enhancement] [Zscaler ZPA] Make enhancement in connector with best p…
eec22fe 
…ractices implementation (elastic#4648)

* Update Aggregation visualizations to Lens, Add an on_failure processor to the convert, geo_ip, uri_parts and date processors, and mapped to related ecs field

* Update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:zscaler_zpa Zscaler Private Access

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinit-chauhan @elasticmachine @P1llus