Repository navigation
ti_misp: honor preserve_original_event tag - #5190
Merged
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Previously there was no remove processor that would delete event.original when preserve_original_event was not present. In addition to this, the tags field was clobbered by the misp.tag script processor, so be more careful with retaining existing tags. Also clean up some potential null deref issues.
🌐 Coverage report
|
efd6
marked this pull request as ready for review
February 7, 2023 02:16
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
P1llus
approved these changes
Feb 7, 2023
|
Package ti_misp - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=ti_misp |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
Previously there was no remove processor that would delete event.original when preserve_original_event was not present. In addition to this, the tags field was clobbered by the misp.tag script processor, so be more careful with retaining existing tags. Also clean up some potential null deref issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously there was no remove processor that would delete event.original when preserve_original_event was not present. In addition to this, the tags field was clobbered by the misp.tag script processor, so be more careful with retaining existing tags. Also clean up some potential null deref issues.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots