[integrations] - Making multiple integrations GA by ShourieG · Pull Request #5677 · elastic/integrations

ShourieG · 2023-03-24T12:36:47Z

Type of change

Enhancement

What does this PR do?

Makes the following integrations/ data streams in certain integrations GA and updates the version to 1.0.0 :

Barracuda CloudGen
Box Events
Cisco Aironet*
Cisco Umbrella
Cloudflare Logpush
Cyberark PTA
Darktrace
F5 BIG-IP
Github
Infoblox BloxOne DDI
Jamf Compliance Reporter
LastPass
Microsoft Exchange Message Trace
PingOne
Rapid7 Threat Command
Slack Logs*
Sophos Central
Trend Micro Vision One

*Community developed

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Related issues

Closes Security Integrations GA #5033

ShourieG · 2023-03-24T12:39:13Z

Query: Should ECS version also be updated to the latest in every GA'd integration ?

ShourieG · 2023-03-24T12:44:30Z

@jamiehynds The Initial PR for GA is up. Just some concerns :

Some of the integrations here still use older ECS of 8.4.
Cloud Flare Logpush GCS stream is not stress tested by users yet due to adoption rates
Packages like Rapid7 Threat Command and Journald Input only had initial commits before and very low versions like 0.0.x

elasticmachine · 2023-03-24T12:49:36Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-31T11:30:01.097+0000
Duration: 24 min 30 sec

Test stats 🧪

Test	Results
Failed	0
Passed	295
Skipped	0
Total	295

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

jamiehynds · 2023-03-24T14:01:27Z

Journald Input only had initial commits before and very low version like 0.0.x

@andrewkroh do you know what we use the Journald input for and if there's any blockers to GA'ing it?

elasticmachine · 2023-03-24T14:40:27Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`39/39`)	💚
Files	100.0% (`93/93`)	💚
Classes	100.0% (`93/93`)	💚
Methods	98.222% (`718/731`)	👍 4.888
Lines	95.806% (`20925/21841`)	👎 -4.194
Conditionals	100.0% (`0/0`)	💚

elasticmachine · 2023-03-24T18:21:17Z

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh · 2023-03-28T02:37:06Z

We could make the journald input GA. AFAIK there are no known problems with it, and one feature request in #4032. And I have been asked to make the input GA in the past (and definitely forgot to open an issue for that).

Given that we haven't made the journald custom input package GA yet, I wonder if it would be a good time to convert it to an "input package". @P1llus, would this be worthwhile to do before making it GA?

P1llus · 2023-03-28T05:26:05Z

@andrewkroh I would highly recommend converting this as part of going GA, thats a great initative.

That also means we would have to set minimum version to 8.8 though, as that is when input packages goes GA right @hop-dev ?

hop-dev · 2023-03-28T09:13:12Z

Yes thats right, input packages can only be GA if they specify kibana version 8.8 or greater. This was introduced in package spec 2.6.0.

ShourieG · 2023-03-30T09:34:14Z

@jamiehynds for now removing the Journald input from the list and making the rest GA. Will take it up in 8.8 as suggested by converting it to an input package

andrewkroh · 2023-03-30T13:18:51Z

I created an issue for journald. #5750

ShourieG · 2023-03-31T09:02:05Z

@kcreddy I've resolved all the PR suggestions

kcreddy

LGTM 👍🏼

ShourieG · 2023-03-31T12:01:24Z

@jamiehynds PR is merged

elasticmachine · 2023-03-31T12:19:53Z

Package barracuda_cloudgen_firewall - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=barracuda_cloudgen_firewall

elasticmachine · 2023-03-31T12:24:44Z

Package box_events - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=box_events

elasticmachine · 2023-03-31T12:29:34Z

Package cisco_aironet - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=cisco_aironet

elasticmachine · 2023-03-31T12:33:56Z

Package cisco_umbrella - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

elasticmachine · 2023-03-31T12:38:48Z

Package cloudflare_logpush - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

elasticmachine · 2023-03-31T12:43:18Z

Package cyberark_pta - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=cyberark_pta

elasticmachine · 2023-03-31T12:47:57Z

Package darktrace - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=darktrace

elasticmachine · 2023-03-31T12:53:15Z

Package f5_bigip - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=f5_bigip

elasticmachine · 2023-03-31T12:53:17Z

Package github - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=github

elasticmachine · 2023-03-31T12:57:41Z

Package infoblox_bloxone_ddi - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

elasticmachine · 2023-03-31T13:08:14Z

Package jamf_compliance_reporter - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter

elasticmachine · 2023-03-31T13:08:15Z

Package lastpass - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=lastpass

elasticmachine · 2023-03-31T13:12:28Z

Package microsoft_exchange_online_message_trace - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

elasticmachine · 2023-03-31T13:21:11Z

Package ping_one - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=ping_one

elasticmachine · 2023-03-31T13:26:13Z

Package slack - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=slack

elasticmachine · 2023-03-31T13:31:21Z

Package sophos_central - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=sophos_central

elasticmachine · 2023-03-31T13:35:45Z

Package ti_rapid7_threat_command - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

elasticmachine · 2023-03-31T13:42:12Z

Package trend_micro_vision_one - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one

* taking integrations to ga * updated changelog & data streams * fixed sophos central issue * reverting ga for journaled input * updated manifests and changelogs * updated jamp changelog * updated manifests * removed release parameter from journald package manifest * setting experimental release tag back to journald input

taking integrations to ga

3eaa056

ShourieG requested review from a team as code owners March 24, 2023 12:36

ShourieG requested review from belimawr and fearful-symmetry March 24, 2023 12:36

ShourieG self-assigned this Mar 24, 2023

ShourieG added the 8.7 candidate label Mar 24, 2023

ShourieG requested review from P1llus and kcreddy March 24, 2023 12:37

ShourieG changed the title ~~taking integrations to ga~~ [integrations] - Making multiple integrations GA Mar 24, 2023

updated changelog & data streams

7d5645c

fixed sophos central issue

629acfe

ShourieG added the Team:Security-External Integrations label Mar 24, 2023

merged with upstream and fixed conflicts

1b2b086

ShourieG added 2 commits March 30, 2023 14:48

reverting ga for journaled input

dc49c7d

Merge remote-tracking branch 'upstream/main' into ga/integrations

76991dc

kcreddy reviewed Mar 30, 2023

View reviewed changes

updated manifests and changelogs

7c59f43

ShourieG added 2 commits March 31, 2023 14:34

updated jamp changelog

dbad181

updated manifests

2b9c38f

kcreddy approved these changes Mar 31, 2023

View reviewed changes

rdner reviewed Mar 31, 2023

View reviewed changes

Comment thread packages/cisco_umbrella/manifest.yml

Comment thread packages/github/manifest.yml

Comment thread packages/journald/manifest.yml Outdated

Comment thread packages/sophos_central/manifest.yml

removed release parameter from journald package manifest

15cba6a

rdner approved these changes Mar 31, 2023

View reviewed changes

setting experimental release tag back to journald input

d54d433

ShourieG merged commit de7f8e8 into elastic:main Mar 31, 2023

ShourieG deleted the ga/integrations branch March 31, 2023 11:59

Conversation

ShourieG commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

What does this PR do?

Checklist

Related issues

Uh oh!

ShourieG commented Mar 24, 2023

Uh oh!

ShourieG commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

jamiehynds commented Mar 24, 2023

Uh oh!

elasticmachine commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

elasticmachine commented Mar 24, 2023

Uh oh!

andrewkroh commented Mar 28, 2023

Uh oh!

P1llus commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hop-dev commented Mar 28, 2023

Uh oh!

ShourieG commented Mar 30, 2023

Uh oh!

andrewkroh commented Mar 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShourieG commented Mar 31, 2023

Uh oh!

kcreddy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShourieG commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

Uh oh!

elasticmachine commented Mar 31, 2023

ShourieG commented Mar 24, 2023 •

edited

Loading

ShourieG commented Mar 24, 2023 •

edited

Loading

elasticmachine commented Mar 24, 2023 •

edited

Loading

elasticmachine commented Mar 24, 2023 •

edited

Loading

P1llus commented Mar 28, 2023 •

edited

Loading