Skip to content

[fortinet_fortigate] Fix syslog KV split to take into account quoted values. - #6276

Merged
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:fix/fortigate-kv-parsing
May 22, 2023
Merged

[fortinet_fortigate] Fix syslog KV split to take into account quoted values.#6276
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:fix/fortigate-kv-parsing

Conversation

@marc-gr

@marc-gr marc-gr commented May 22, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix syslog KV split to take into account quoted values and be more defensive.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] bugfix Pull request that fixes a bug issue labels May 22, 2023
@marc-gr
marc-gr requested a review from a team as a code owner May 22, 2023 08:24
@elasticmachine

elasticmachine commented May 22, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented May 22, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T08:31:51.177+0000

  • Duration: 16 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 22, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (38/38) 💚
Lines 90.952% (1156/1271) 👎 -2.636
Conditionals 100.0% (0/0) 💚

ShourieG
ShourieG approved these changes May 22, 2023
View reviewed changes

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr
marc-gr merged commit cb00b7b into elastic:main May 22, 2023
@marc-gr
marc-gr deleted the fix/fortigate-kv-parsing branch May 22, 2023 11:16
@elasticmachine

elasticmachine commented May 22, 2023

Copy link
Copy Markdown

Package fortinet_fortigate - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@andrewkroh andrewkroh added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs and removed Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[fortinet_fortigate] Fix syslog KV split to take into account quoted …
aceeb5c 
…values. (elastic#6276)

* Fix syslog KV split to take into account quoted values.

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-gr @elasticmachine @ShourieG @andrewkroh