Skip to content

[Fortinet] Add support for 7.4 events - #8036

Merged
marc-gr merged 9 commits into
elastic:mainfrom
marc-gr:fortinet-7x-support
Oct 30, 2023
Merged

marc-gr merged 9 commits into
elastic:mainfrom
marc-gr:fortinet-7x-support

Conversation

@marc-gr

@marc-gr marc-gr commented Oct 2, 2023 •

Copy link
Copy Markdown
Contributor

Proposed commit message

Adds more test coverage for 6.2 events
Adds definitions for 7.4 event fields
Adds fixes for 7.4 events
Adds 7.4 events test coverage
Adds network_direction processor in addition to interface based direction resolution
Fix interface options for udp and tcp inputs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@marc-gr marc-gr added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Oct 2, 2023
@marc-gr
marc-gr force-pushed the fortinet-7x-support branch from acf3113 to 7dc4731 Compare October 2, 2023 08:50
@elasticmachine

elasticmachine commented Oct 2, 2023 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T08:32:47.295+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Oct 2, 2023 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (40/40) 💚 66.667
Lines 92.686% (1318/1422) 👎 -7.314
Conditionals 100.0% (0/0) 💚

@marc-gr
marc-gr force-pushed the fortinet-7x-support branch from 9e9ef65 to 789be44 Compare October 26, 2023 15:18
@marc-gr
marc-gr marked this pull request as ready for review October 26, 2023 15:20
@marc-gr
marc-gr requested a review from a team as a code owner October 26, 2023 15:20
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment thread packages/fortinet_fortigate/data_stream/log/agent/stream/log.yml.hbs Outdated
Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
@marc-gr
marc-gr requested a review from efd6 October 27, 2023 09:07

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only which probably should happen in another PR. LGTM

Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
Comment thread packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/utm.yml Outdated
@marc-gr
marc-gr merged commit e17b11b into elastic:main Oct 30, 2023
@marc-gr
marc-gr deleted the fortinet-7x-support branch October 30, 2023 09:08
@elasticmachine

Copy link
Copy Markdown

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

3 similar comments
@elasticmachine

Copy link
Copy Markdown

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@elasticmachine

Copy link
Copy Markdown

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@elasticmachine

Copy link
Copy Markdown

Package fortinet_fortigate - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@andrewkroh andrewkroh added the Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs label Jul 22, 2024
@andrewkroh andrewkroh removed the Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Add more 6.2 event samples

* Add 7.4 samples and fields

* Bump version and add changelog entry

* Add network_direction processor and improve tls mappings

* Add end block comments and remove unused index variable

* Suggested changes on modified processors

* Unquote all processors conditions for consistency

* Add nullcheck on network direction condition

* Clean value templates and remove  null checks in pipelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fortinet_fortigate] Use network direction processor to definenetwork.direction Fortinet | Forti-OS 7.x Support

4 participants