Skip to content

cisco_meraki,zscalar_zpa: fix field mappings and definitions - #8341

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:ep1461-cisko_meraki-zscalar_zpa
Oct 31, 2023
Merged

efd6 merged 1 commit into
elastic:mainfrom
efd6:ep1461-cisko_meraki-zscalar_zpa

Conversation

@efd6

@efd6 efd6 commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Proposed commit message

cisco_meraki:

  • add missing definitions for client.as.{number,organization.name).

zscalar_zpa:

  • rename client.as.{asn,organization_name} to their corresponding ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:zscaler_zpa Zscaler Private Access Integration:cisco_meraki Cisco Meraki labels Oct 30, 2023
@efd6 efd6 self-assigned this Oct 30, 2023
@efd6
efd6 force-pushed the ep1461-cisko_meraki-zscalar_zpa branch from 5a04f63 to 5a9534f Compare October 30, 2023 20:42
@elasticmachine

elasticmachine commented Oct 30, 2023 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T20:56:45.424+0000

  • Duration: 18 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

cisco_meraki:
* add missing definitions for client.as.{number,organization.name).

zscalar_zpa:
* rename client.as.{asn,organization_name} to their corresponding ECS
  fields.
@efd6
efd6 force-pushed the ep1461-cisko_meraki-zscalar_zpa branch from 5a9534f to e674bff Compare October 30, 2023 20:56
@elasticmachine

elasticmachine commented Oct 30, 2023 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (14/14) 💚
Classes 100.0% (14/14) 💚
Methods 100.0% (125/125) 💚 10.294
Lines 93.535% (2749/2939) 👎 -5.598
Conditionals 100.0% (0/0) 💚

@efd6
efd6 marked this pull request as ready for review October 30, 2023 21:27
@efd6
efd6 requested a review from a team as a code owner October 30, 2023 21:27
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 merged commit 4446b87 into elastic:main Oct 31, 2023
@elasticmachine

Copy link
Copy Markdown

Package cisco_meraki - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

@elasticmachine

Copy link
Copy Markdown

Package zscaler_zpa - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

@efd6
efd6 deleted the ep1461-cisko_meraki-zscalar_zpa branch February 5, 2025 22:08
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…#8341)

cisco_meraki:
* add missing definitions for client.as.{number,organization.name).

zscalar_zpa:
* rename client.as.{asn,organization_name} to their corresponding ECS
  fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_meraki Cisco Meraki Integration:zscaler_zpa Zscaler Private Access

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants