Skip to content

#8218: Ensure atomic creation of PQ checkpoints - #9303

Closed
original-brownbear wants to merge 1 commit into
elastic:masterfrom
original-brownbear:fix-missing-checkpoint-content
Closed

original-brownbear wants to merge 1 commit into
elastic:masterfrom
original-brownbear:fix-missing-checkpoint-content

Conversation

@original-brownbear

Copy link
Copy Markdown
Contributor

Fixes #8218 by ensuring that Checkpoint creation is actually atomic via:

  • Create checkpoint file at temporary path
    • Create + subsequent write can never be atomic -> write to temp path first
  • Move it to the actual checkpoint path
    • Move is atomic on effectively all filesystems we support

@danhermann

Copy link
Copy Markdown
Contributor

LGTM!

@original-brownbear

Copy link
Copy Markdown
Contributor Author

@danhermann thanks!

@elasticsearch-bot

Copy link
Copy Markdown

Armin Braun merged this into the following branches!

Branch Commits
master 908ac09
6.x 2539d88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants