Repository navigation
Conversation
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 16, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 16, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug in the
StatsEventFactoryprevents it from reporting the total queued items across multiple pipelines.When iterating over the list of stats, we need to sum up matching items instead of setting the total to the last one seen.
All of the testing infrastructure for this code relies on injecting a single pipeline directly into the
logstash.yml, so I don't have an adequate way to improve coverage without significant effort.