Repository navigation
Drop JDK 11 support - #16443
Merged
Merged
Drop JDK 11 support#16443
Conversation
jsvd
reviewed
Sep 13, 2024
jsvd
requested changes
Sep 13, 2024
jsvd
left a comment
Member
There was a problem hiding this comment.
Please check Java version references in
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
jsvd
reviewed
Sep 13, 2024
jsvd
reviewed
Sep 13, 2024
jsvd
reviewed
Sep 13, 2024
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
|
💚 Build Succeeded
History
cc @andsel |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Remove support for JDK 11
What does this PR do?
Updates the
jvm.optionsandJvmOptionsParserto remove support for JDK 11. If the options parser identifies that the running JVM is less than 17, it refuses to start.Why is it important/What is the impact to the user?
If a user runs Logstash with a hosted JDK and not the one bundled with Logstash distribution, like setting a specific
LS_JAVA_HOME, which is minor than JDK 17 then Logstash refuses to start. Has to provide at least a JDK 17 or unset theLS_JAVA_HOMEand let Logstash uses the bundled JDK.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs