Skip to content

remove ingest-converter - #16453

Merged
kaisecheng merged 2 commits into
elastic:mainfrom
kaisecheng:remove_ingest_converter
Sep 16, 2024
Merged

kaisecheng merged 2 commits into
elastic:mainfrom
kaisecheng:remove_ingest_converter

Conversation

@kaisecheng

@kaisecheng kaisecheng commented Sep 13, 2024 •

Copy link
Copy Markdown
Contributor

Release notes

Removed the tool Ingest Converter

What does this PR do?

Logstash project has a tool called ingest converter which can do a small set of ingest pipeline processors.
This commit removed ingest converter from the project, including docs and script in /bin

Why is it important/What is the impact to the user?

The tool is no longer relevant given that we have elastic_integration-filter to handle ingest pipeline.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Logstash can build and run
  • DRA job run successfully
  • Exhaustive test run successfully

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kaisecheng
kaisecheng marked this pull request as ready for review September 13, 2024 18:31
@kaisecheng

Copy link
Copy Markdown
Contributor Author

exhaustive test is green

@jsvd jsvd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisecheng
kaisecheng merged commit 4e82655 into elastic:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants