Skip to content

set allow_superuser to false as default - #16558

Merged
kaisecheng merged 3 commits into
elastic:mainfrom
kaisecheng:set_allow_superuser_false
Oct 31, 2024
Merged

kaisecheng merged 3 commits into
elastic:mainfrom
kaisecheng:set_allow_superuser_false

Conversation

@kaisecheng

@kaisecheng kaisecheng commented Oct 15, 2024 •

Copy link
Copy Markdown
Contributor

Release notes

Running as superuser is disabled by default. To continue running Logstash as superuser temporarily after the upgrade, set 'allow_superuser' to true.

What does this PR do?

  • set allow_superuser as false by default for v9
  • change the buildkite image of ruby unit test to non-root

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Comment thread logstash-core/lib/logstash/runner.rb Outdated
deprecation_logger.deprecated("NOTICE: Running Logstash as superuser is not recommended and won't be allowed in the future. Set 'allow_superuser' to 'false' to avoid startup errors in future releases.")
deprecation_logger.deprecated("NOTICE: Running Logstash as superuser will be completely disallowed in future versions. " +
"To prepare for this and avoid startup errors in future releases, it is strongly recommended to set 'allow_superuser' to false now " +
"and adjust your configuration accordingly.")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy from the companion pr

Comment thread logstash-core/lib/logstash/runner.rb Outdated
@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@jsvd
jsvd self-requested a review October 28, 2024 09:51

@jsvd jsvd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheVastyDeep

Copy link
Copy Markdown

@jsvd @kaisecheng You need to update the comment in logstash.yml that says the default is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants