Skip to content

feat: allow notarization on macOS versions down to 10.15 - #201

Merged
felixrieseberg merged 6 commits into
electron:mainfrom
pjaspinski:notarytool-by-path
Sep 17, 2024
Merged

feat: allow notarization on macOS versions down to 10.15#201
felixrieseberg merged 6 commits into
electron:mainfrom
pjaspinski:notarytool-by-path

Conversation

@pjaspinski

@pjaspinski pjaspinski commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

More info in the linked issue: closes #200

@pjaspinski
pjaspinski requested a review from a team as a code owner June 6, 2024 22:15
erickzhao
erickzhao reviewed Jun 6, 2024
View reviewed changes
Comment thread src/types.ts Outdated
erickzhao
erickzhao reviewed Jun 6, 2024
View reviewed changes

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjaspinski I also had a question since I'm not super familiar with legacy versions of macOS:

Apple's Notarization troubleshooting documentation seems to tell users to use macOS SDK 10.9 or later because Mavericks changed how codesigning works:
https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087723

Do we want to align with that 10.9 minimum in the documentation in this case as well?

@pjaspinski pjaspinski changed the title Allow notarization on macOS versions down to 10.5 feat: Allow notarization on macOS versions down to 10.5 Jun 7, 2024
@pjaspinski pjaspinski changed the title feat: Allow notarization on macOS versions down to 10.5 feat: Allow notarization on macOS versions down to 10.15 Jun 7, 2024
@pjaspinski

pjaspinski commented Jun 7, 2024

Copy link
Copy Markdown
Contributor Author

@erickzhao I made a mistake - notarytool is supported down to macOS version 10.15 (not 10.5). So the requirement that you mentioned is always met.

@pjaspinski
pjaspinski requested a review from erickzhao June 10, 2024 10:40
erickzhao
erickzhao requested changes Jun 11, 2024
View reviewed changes

@erickzhao erickzhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more doc fix, but the overall concept LGTM

Comment thread README.md Outdated
@pjaspinski @erickzhao
Update README.md
3a36a70 
Co-authored-by: Erick Zhao <erick@hotmail.ca>
@erickzhao erickzhao changed the title feat: Allow notarization on macOS versions down to 10.15 feat: allow notarization on macOS versions down to 10.15 Jul 15, 2024
@erickzhao erickzhao self-assigned this Aug 20, 2024
dsanders11
dsanders11 reviewed Aug 24, 2024
View reviewed changes
Comment thread src/notarytool.ts Outdated
Comment thread src/notarytool.ts Outdated
@felixrieseberg

felixrieseberg commented Sep 17, 2024

Copy link
Copy Markdown
Member

This is a good PR and we'll merge it in, I just want to be clear: We're not supporting older versions of macOS. Using a custom notarization tool is fully unsupported.

@felixrieseberg
felixrieseberg merged commit 268fa30 into electron:main Sep 17, 2024
@continuous-auth

continuous-auth Bot commented Sep 17, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsanders11 dsanders11 dsanders11 left review comments
@erickzhao erickzhao erickzhao approved these changes

Assignees

@erickzhao erickzhao

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow notarization on macOS versions down to 10.15

4 participants

@pjaspinski @felixrieseberg @dsanders11 @erickzhao